From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder
Date: Tue, 22 Jan 2019 22:42:28 +0200 [thread overview]
Message-ID: <20190122204228.GD3264@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdWYgAnxxUud89uGWBePK6UfVt2T=gumMmzs_SF95Ap36Q@mail.gmail.com>
Hi Geert,
On Thu, Jan 17, 2019 at 11:21:32AM +0100, Geert Uytterhoeven wrote:
> On Thu, Jan 17, 2019 at 3:07 AM Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
> > output when the LVDS0 encoder is used. Enable it despite its output not
> > being connected.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> > @@ -443,6 +443,8 @@
> > };
> >
> > &lvds1 {
>
> Would it make sense to add a comment
>
> /* Must be enabled to supply a pixel clock to the DU for the DPAD
> output when lvds0 is used */
>
> also for D3?
Good point, I'll add it for both.
> > + status = "okay";
> > +
> > clocks = <&cpg CPG_MOD 727>,
> > <&x13_clk>,
> > <&extal_clk>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-01-22 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 1:49 [PATCH 0/6] R-Car DU DPAD support for D3 and E3 Laurent Pinchart
2019-01-17 1:49 ` [PATCH 1/6] drm: rcar-du: Simplify encoder registration Laurent Pinchart
2019-01-17 1:49 ` [PATCH 2/6] drm: rcar-du: lvds: Don't fail probe if output is not connected on D3/E3 Laurent Pinchart
2019-01-17 8:23 ` Sergei Shtylyov
2019-01-17 1:49 ` [PATCH 3/6] drm: rcar-du: lvds: Add API to enable/disable clock output Laurent Pinchart
2019-01-17 1:49 ` [PATCH 4/6] drm: rcar-du: Turn LVDS clock output on/off for DPAD0 output on D3/E3 Laurent Pinchart
2019-01-17 1:49 ` [PATCH 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder Laurent Pinchart
2019-01-17 10:21 ` Geert Uytterhoeven
2019-01-22 20:42 ` Laurent Pinchart [this message]
2019-01-17 1:49 ` [PATCH 6/6] arm64: dts: renesas: r8a77995: draak: " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122204228.GD3264@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).