From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: rcar: refactor TCYC handling
Date: Wed, 23 Jan 2019 18:39:26 +0100 [thread overview]
Message-ID: <20190123173926.GA956@kunai> (raw)
In-Reply-To: <20190123102506.hi6tvyby5f4wbaho@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Wed, Jan 23, 2019 at 11:25:06AM +0100, Simon Horman wrote:
> On Mon, Jan 21, 2019 at 06:08:00PM +0100, Wolfram Sang wrote:
> > The latest documentation made it clear that we need to initialize the
> > TCYC value independently of DMA. Simplify the code to do that.
>
> Hi Wolfram,
>
> I see TCYC bit 6 is no longer used after this patch.
> Does that warrant a mention in the changelog?
Do you think so? The old code used TCYC06 (wrongly) for non-DMA transfers.
The new code sets TCYC up "independently from DMA" <- commit message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-23 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:07 [PATCH 0/2] i2c: rcar: minor upporting from BSP Wolfram Sang
2019-01-21 17:07 ` [PATCH 1/2] i2c: rcar: comment maintenance Wolfram Sang
2019-01-23 10:23 ` Simon Horman
2019-02-05 13:33 ` Wolfram Sang
2019-01-21 17:08 ` [PATCH 2/2] i2c: rcar: refactor TCYC handling Wolfram Sang
2019-01-23 10:25 ` Simon Horman
2019-01-23 17:39 ` Wolfram Sang [this message]
2019-01-24 12:41 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123173926.GA956@kunai \
--to=wsa@the-dreams.de \
--cc=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).