From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Chris Brandt <chris.brandt@renesas.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] i2c: riic: Add Runtime PM support
Date: Mon, 15 Apr 2019 14:17:18 +0200 [thread overview]
Message-ID: <20190415121718.gdowmtgwqi2aa4zp@ninjato> (raw)
In-Reply-To: <20190320103003.20107-1-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Wed, Mar 20, 2019 at 11:30:03AM +0100, Geert Uytterhoeven wrote:
> - Replace explicit clock handling by Runtime PM calls,
> - Streamline Runtime PM handling in error paths,
> - Enable Runtime PM in .probe(),
> - Disable Runtime PM in .remove(),
> - Make sure the device is runtime-resumed when disabling interrupts in
> .remove().
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> I don't think it's worth splitting off the last bug fix in a separate
> (first) patch, using explicit clock handling, as that will be replaced
> immediately by Runtime PM calls.
Chris, what do you think about this patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-15 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 10:30 [PATCH] i2c: riic: Add Runtime PM support Geert Uytterhoeven
2019-03-20 16:20 ` Niklas Söderlund
2019-04-15 12:17 ` Wolfram Sang [this message]
2019-04-15 12:43 ` Chris Brandt
2019-04-15 12:46 ` Wolfram Sang
2019-04-15 18:56 ` Chris Brandt
2019-04-23 21:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415121718.gdowmtgwqi2aa4zp@ninjato \
--to=wsa@the-dreams.de \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).