From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v2 2/2] drm: rcar-du: kms: Expand comment in vsps parsing routine
Date: Sun, 25 Aug 2019 16:01:35 +0200 [thread overview]
Message-ID: <20190825140135.12150-3-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20190825140135.12150-1-jacopo+renesas@jmondi.org>
Exand comment in the 'vsps' parsing routine to specify why the LIF
channel index is defaulted to 0 in case the second cell of the property
is not specified.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 2dc9caee8767..0d59f390de19 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -585,7 +585,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
vsps[j].crtcs_mask |= BIT(i);
- /* Store the VSP pointer and pipe index in the CRTC. */
+ /*
+ * Store the VSP pointer and pipe index in the CRTC. If the
+ * second cell of the 'vsps' specifier isn't present, default
+ * to 0 to remain compatible with older DT bindings.
+ */
rcdu->crtcs[i].vsp = &rcdu->vsps[j];
rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
}
--
2.23.0
next prev parent reply other threads:[~2019-08-25 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 14:01 [PATCH v2 0/2] arm64: dts: renesas: Add LIF channel to 'vsps' property Jacopo Mondi
2019-08-25 14:01 ` [PATCH v2 1/2] arm64: dts: renesas: Add LIF channel indices to vsps property Jacopo Mondi
2019-08-26 7:39 ` Geert Uytterhoeven
2019-08-25 14:01 ` Jacopo Mondi [this message]
2019-08-25 18:06 ` [PATCH v2 2/2] drm: rcar-du: kms: Expand comment in vsps parsing routine Laurent Pinchart
2019-08-26 7:23 ` Jacopo Mondi
2019-08-27 13:23 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190825140135.12150-3-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).