From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB1ABC4CEC9 for ; Wed, 18 Sep 2019 22:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACA7221848 for ; Wed, 18 Sep 2019 22:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PzmVX48A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388373AbfIRWJD (ORCPT ); Wed, 18 Sep 2019 18:09:03 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:44064 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388365AbfIRWJD (ORCPT ); Wed, 18 Sep 2019 18:09:03 -0400 Received: from pendragon.ideasonboard.com (unknown [62.28.174.186]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5956D325; Thu, 19 Sep 2019 00:08:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1568844539; bh=HcauoKt1vq8jCosZ7BbCDgBKH/ZpL1vJfjx1ykYzFxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PzmVX48AsV5HGYshrcWk1ifMgVw7JS7T6nF0dUGR9i3uMhef013eosvBslnPD+GHi MVySJj/QqZOyO3z4hewPIKvkZ7MIxQmhvBHObpAUnyedTVGw36c1OBobX4HwZxUjjT JYejYHasiTh+lopTSJVsrTbUnWoKHMdK9ZkbvyTg= Date: Thu, 19 Sep 2019 01:08:49 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org, horms@verge.net.au, uli+renesas@fpond.eu, VenkataRajesh.Kalakodima@in.bosch.com, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Message-ID: <20190918220849.GA10104@pendragon.ideasonboard.com> References: <20190906135436.10622-1-jacopo+renesas@jmondi.org> <20190906135436.10622-2-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190906135436.10622-2-jacopo+renesas@jmondi.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Jacopo, Thank you for the patch. On Fri, Sep 06, 2019 at 03:54:28PM +0200, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: Jacopo Mondi With the small issues pointed out by Kieran and Rob fixed, Reviewed-by: Laurent Pinchart > --- > .../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml > > diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > new file mode 100644 > index 000000000000..9e5922689cd7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Color Management Module (CMM) > + > +maintainers: > + - Laurent Pinchart > + - Kieran Bingham > + - Jacopo Mondi > + > +description: |+ > + Renesas R-Car color management module connected to R-Car DU video channels. > + It provides image enhancement functions such as 1-D look-up tables (LUT), > + 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color > + space conversion (CSC). > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r8a7795-cmm > + - renesas,r8a7796-cmm > + - renesas,r8a77965-cmm > + - renesas,r8a77990-cmm > + - renesas,r8a77995-cmm > + - enum: > + - renesas,rcar-gen3-cmm > + - renesas,rcar-gen2-cmm > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + cmm0: cmm@fea40000 { > + compatible = "renesas,r8a7796-cmm"; > + reg = <0 0xfea40000 0 0x1000>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > + resets = <&cpg 711>; > + }; -- Regards, Laurent Pinchart