From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] thermal: rcar_thermal: Remove temperature bound
Date: Wed, 15 Jan 2020 14:45:59 +0100 [thread overview]
Message-ID: <20200115134559.GA945270@oden.dyn.berto.se> (raw)
In-Reply-To: <a98baf8f-e2ef-d77d-ff3c-f5838e268dd7@linaro.org>
Hi Daniel,
Thanks for your feedback.
On 2020-01-15 14:24:30 +0100, Daniel Lezcano wrote:
> On 14/01/2020 23:29, Niklas Söderlund wrote:
> > The hardware manual states that the operation of the sensor is not
> > guaranteed outside the range of -40°C to 125°C, not that the readings
> > are invalid. Remove the bound check and try to deliver temperature
> > readings even if we are outside the guaranteed operation range.
>
> And what if the sensor is returning crap in this out-of-range operation?
I'm not sure what is worse, reporting an untrue (but still outside the
guaranteed operation range) extreme temperature or failing with -EIO.
The view of the hardware guys is that it's better to report what the
sensor indicates then to return -EIO.
>
>
>
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> > drivers/thermal/rcar_thermal.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> > index d0873de718da9218..2ae60b27a0183db1 100644
> > --- a/drivers/thermal/rcar_thermal.c
> > +++ b/drivers/thermal/rcar_thermal.c
> > @@ -275,13 +275,6 @@ static int rcar_thermal_get_current_temp(struct rcar_thermal_priv *priv,
> > tmp = MCELSIUS((priv->ctemp * 5) - 60);
> > mutex_unlock(&priv->lock);
> >
> > - if ((tmp < MCELSIUS(-45)) || (tmp > MCELSIUS(125))) {
> > - struct device *dev = rcar_priv_to_dev(priv);
> > -
> > - dev_err(dev, "it couldn't measure temperature correctly\n");
> > - return -EIO;
> > - }
> > -
> > *temp = tmp;
> >
> > return 0;
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-01-15 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 22:29 [PATCH 0/2] thermal: rcar_{gen3_}thermal: Remove temperature bound Niklas Söderlund
2020-01-14 22:29 ` [PATCH 1/2] thermal: rcar_thermal: " Niklas Söderlund
2020-01-15 13:24 ` Daniel Lezcano
2020-01-15 13:45 ` Niklas Söderlund [this message]
2020-01-15 18:15 ` Daniel Lezcano
2020-01-15 18:39 ` Niklas Söderlund
2020-01-15 18:52 ` Daniel Lezcano
2020-01-15 19:00 ` Niklas Söderlund
2020-01-14 22:29 ` [PATCH 2/2] thermal: rcar_gen3_thermal: " Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115134559.GA945270@oden.dyn.berto.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).