From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Paul Barker" <paul.barker.ct@bp.renesas.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] net: ravb: Fix registered interrupt names
Date: Thu, 25 Apr 2024 07:16:37 -0700 [thread overview]
Message-ID: <20240425071637.5fe0199d@kernel.org> (raw)
In-Reply-To: <1f131230-56a5-4547-bc77-c508e61e8a55@lunn.ch>
On Thu, 25 Apr 2024 00:45:35 +0200 Andrew Lunn wrote:
> > Rename the local variable dev_name, as it shadows the dev_name()
> > function, and pre-initialize it, to simplify the code.
>
> Another option is to call dev_alloc_name() soon after alloc_netdev(),
> to give the device its name earlier than register_netdev().
Maybe we shouldn't be advertising that option too broadly. One has to
hold rtnl for that to work. Mostly old and staging drivers seem to do
this. Name are not stable. If other identifiers are available, that's
a better option, IMHO.
next prev parent reply other threads:[~2024-04-25 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 7:45 [PATCH] net: ravb: Fix registered interrupt names Geert Uytterhoeven
2024-04-24 7:56 ` Niklas Söderlund
2024-04-24 9:10 ` Sergey Shtylyov
2024-04-24 9:19 ` Geert Uytterhoeven
2024-04-24 11:13 ` claudiu beznea
2024-04-24 22:45 ` Andrew Lunn
2024-04-25 14:16 ` Jakub Kicinski [this message]
2024-04-25 15:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425071637.5fe0199d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).