From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A3DC3524B for ; Tue, 4 Feb 2020 09:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7F0721927 for ; Tue, 4 Feb 2020 09:12:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=landley-net.20150623.gappssmtp.com header.i=@landley-net.20150623.gappssmtp.com header.b="PGeL2yv8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbgBDJMX (ORCPT ); Tue, 4 Feb 2020 04:12:23 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43218 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgBDJMX (ORCPT ); Tue, 4 Feb 2020 04:12:23 -0500 Received: by mail-pf1-f196.google.com with SMTP id s1so9109384pfh.10 for ; Tue, 04 Feb 2020 01:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=landley-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OEno8L+dLk53KEqvLYXsrFVru+rwMQDT1MCsCBWWmic=; b=PGeL2yv80M/Xyz3TqQfy30bcMf6fkJSWDpFtX5zg7SPUH32tZaavlnLQLUeJvm61jL 7jc1TvZBXJLdQqek38XGa/IQ7IISMsQ6Z+WP22qtzWArm4IfXAQjwdE2Ga+ecWTR7ANa YERU2WTGz9nVMujVG57yYbPj32BYQtRfE68nkB3pq2NXz1q3L+5qIKStEyr+Dhc9FAaX xi6xSd1RLMPZ0pXPtcy8nYd5D924/AO2HMEt0/LdLK7SnHAYIkl+EEjc7yT/DPAWgn6p gkp4llgs/xk3IzTuqHUQ5FfkQ923tWRHTjwVPNc0B2adGWZK2sgorrP3b4qNJ5nL8m+0 MJrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OEno8L+dLk53KEqvLYXsrFVru+rwMQDT1MCsCBWWmic=; b=CW1hQF18JWdGeoKpCZ5/h5/nwFXJwSIOOCxnLW4MA3lotfxaZCePWJOG1TR+W/cxoD SlNy/kuWfmYtMG/V2MFedoRlJAfnyHc5OWd3rm4+dkSkLikvjiI7HR5eixtmNC+ELwxG ClXCSQnhgil30KaQpxEjGo5ety/X8PXHFisrmECXHzMNkdwUb2qWdm10U7Jab0vLdFu5 jujSJkYRHiLgcoqhi758mmGDzLGq4Y3G4+X36fJAHRuT441ksyPTDPjua1Ph692h/axF 807MXaYqqQzrVEghiLxLf9V5zlDj2op7uQ4hKU6qjPlpN6SXA086q5vGrYYCU6GWsC80 qmog== X-Gm-Message-State: APjAAAWzpYIr+wbxyHfxtVmx9oPleYMvre3iw55xQJzrsHSN0Xtq2fUB CbZqWZeKJ6taQJGxZDBXTwRDp0BPu3s= X-Google-Smtp-Source: APXvYqxShwB5mksr4VLPF6EQdoB3Thrj1dJI1OjTYyqPg21c1H8oXz+rhju/pYJoSihlvb9nLNYwrA== X-Received: by 2002:a62:e414:: with SMTP id r20mr29513047pfh.154.1580807542320; Tue, 04 Feb 2020 01:12:22 -0800 (PST) Received: from [192.168.11.4] (softbank126112255110.biz.bbtec.net. [126.112.255.110]) by smtp.googlemail.com with ESMTPSA id b130sm23059315pga.4.2020.02.04.01.12.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2020 01:12:21 -0800 (PST) Subject: Re: [PATCH 0/3] dmaengine: Stear users towards dma_request_slave_chan() To: Geert Uytterhoeven , Peter Ujfalusi Cc: John Paul Adrian Glaubitz , Andy Shevchenko , Vinod Koul , dmaengine , Dan Williams , Linux-sh list , Linux-Renesas References: <20200203101806.2441-1-peter.ujfalusi@ti.com> <701ab186-c240-3c37-2c0b-8ac195f8073f@ti.com> <38f686ae-66fa-0e3a-ec2e-a09fc4054ac4@physik.fu-berlin.de> From: Rob Landley Message-ID: <64cffbfe-a639-c09d-8aa2-fdda8fad2cf7@landley.net> Date: Tue, 4 Feb 2020 03:16:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 2/4/20 2:01 AM, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Feb 4, 2020 at 7:52 AM Peter Ujfalusi wrote: >> On 03/02/2020 22.34, Geert Uytterhoeven wrote: >>> On Mon, Feb 3, 2020 at 9:21 PM John Paul Adrian Glaubitz >>> wrote: >>>> On 2/3/20 2:32 PM, Geert Uytterhoeven wrote: >>>>> Both rspi and sh-msiof have users on legacy SH (i.e. without DT): >>>> >>>> FWIW, there is a patch set by Yoshinori Sato to add device tree support >>>> for classical SuperH hardware. It was never merged, unfortunately :(. >>> >>> True. >>> >>>>> Anyone who cares for DMA on SuperH? >>>> >>>> What is DMA used for on SuperH? Wouldn't dropping it cut support for >>>> essential hardware features? >>> >>> It may make a few things slower. The j-core stuff has DMA but we haven't hooked it up to dmaengine yet. (It's on the todo list but pretty far down.) I fought with dmaengine in a 7760 board in 2018, and got it to run its tests but the ship deadline arrived before I got the ethernet working with it. I found the documentation fairly impenetrable, is there a good primer on what's _current_ for new implementations? (I had similar questions for gpio. It's easy to google for "here's how you did it in 2010"...) >> I would not drop DMA support but I would suggest to add dma_slave_map >> for non DT boot so the _compat() can be dropped. > > Which is similar in spirit to gpiod_lookup and clk_register_clkdev(), > right? > >> Imho on lower spec SoC (and I believe SuperH is) the DMA makes big >> difference offloading data movement from the CPU. > > Assumed it is actually used... The turtle boards need it USB, ethernet, and sdcard, but Rich Felker hasn't finished the j32 port yet (we just got him the updated docs last month) and the existing implementation is nommu so the things that are using it are reaching around behind the OS's back... Rob