From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0121C433E0 for ; Fri, 3 Jul 2020 11:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B01E207DA for ; Fri, 3 Jul 2020 11:05:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o+WYd9Lj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbgGCLFQ (ORCPT ); Fri, 3 Jul 2020 07:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgGCLFP (ORCPT ); Fri, 3 Jul 2020 07:05:15 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1378CC08C5C1 for ; Fri, 3 Jul 2020 04:05:15 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id w3so21216086wmi.4 for ; Fri, 03 Jul 2020 04:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3V8xENO3GmDZDQdIsL9fROUuBGe1Tx1oO+97CX2LTX8=; b=o+WYd9LjQwXET+4lKvAmTVqDbkriQn2PZFkMX+cf7sO6gJ5zFu6/DhSy0j1kHVB71l LDN/Yd/xSBBpvmLwH1lOauD9RCBcY637YAg5vLYpQWiW3Gh/QwpbItyYAwL1+F+3UjaU UoDj1ms1Xc8Ry3kflHXShGqBKhP4RYEeSxCdTNhpJnP+VjKMOw+YLByPMn0IIia2/QsU 9+kYZpn/BMWfx3NmOCLkcrnqEOvupOjNe3XsAP0bAidb5SodU24GqeuXitqHYGqyr97W yAZZuhc6dPORFV95pVU3XtgHH3FCuwlVE6VrWquMnm/F/Q8HHvZZIwcTuyPBYhqAixeF Q40w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3V8xENO3GmDZDQdIsL9fROUuBGe1Tx1oO+97CX2LTX8=; b=NTmK3MoCwN3RyJiCMXqYRfqD5rAct59yMZo0pP1E3Q5zZ7BtLkkkTZ8QS+laguxU76 nBwmWKqYwgxF4kTlFVRYWTyvU4Ujg9KFwTwi+ffC8zxebRmtRpIqK+efO0sMxa+qsV+C 0Akyn0D+eiTunjB/51qWbxvhiYIkkG8LDnP5bWdwPd9e4fKticCOGidQkb0mNe+tPun+ keVe9VipLSGnbi9WOarZFitk6vr9ixmrk9gi5GYtmnyDJ4vaiHAvTmkJlErXDuEsHm1O pXPiI6w4i+CKMAWBjtgmDRUr9v6REluyYFcXEEuGj1QLNt0MZvfP9xgWDGv7ZMUm4KtG gjTg== X-Gm-Message-State: AOAM530ot4gmg0YNnPxf1ddaCk+Gvz6fa9ve8hEcEhmnDfHXFZRua3Pm kM0EVvdcoEaSQgaMTUu1z9DkmA== X-Google-Smtp-Source: ABdhPJzD1B4nfpCSIpNO2dA5tAg0/FjO8jrO54oB6afhVaKV5atXZcdw79oFjb1P+lZWPXBkSmmKWg== X-Received: by 2002:a1c:2392:: with SMTP id j140mr35420704wmj.6.1593774313405; Fri, 03 Jul 2020 04:05:13 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:7019:4e9b:2970:f860? ([2a01:e34:ed2f:f020:7019:4e9b:2970:f860]) by smtp.googlemail.com with ESMTPSA id j16sm13782474wrt.7.2020.07.03.04.05.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 04:05:12 -0700 (PDT) Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices To: Andrzej Pietrasiewicz , Zhang Rui , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Allison Randal , Enrico Weigelt , Gayatri Kammela , Thomas Gleixner , Bartlomiej Zolnierkiewicz , kernel@collabora.com References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com> <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> <625911aa-a55f-dcbf-66b3-719117c6aa32@collabora.com> From: Daniel Lezcano Message-ID: <9fcd1d07-26af-4ff3-56d7-7226ef42a7e6@linaro.org> Date: Fri, 3 Jul 2020 13:05:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <625911aa-a55f-dcbf-66b3-719117c6aa32@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 03/07/2020 12:45, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 03.07.2020 o 08:38, Daniel Lezcano pisze: >> On 03/07/2020 03:49, Zhang Rui wrote: >>> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: >> >> [ ... ] >> >>>>> So the reason is that ->get_temp() is called while the mutex is >>>>> held and >>>>> thermal_zone_device_is_enabled() wants to take the same mutex. >>>> >>>> Yes, that's correct. >>>> >>>>> Is adding a comment to thermal_zone_device_is_enabled() to never >>>>> call >>>>> it while the mutex is held and adding another version of it which >>>>> does >>>>> not take the mutex ok? >>>> >>>> The thermal_zone_device_is_enabled() is only used in two places, acpi >>>> and this imx driver, and given: >>>> >>>> 1. as soon as the mutex is released, there is no guarantee the >>>> thermal >>>> zone won't be changed right after, the lock is pointless, thus the >>>> information also. >>>> >>>> 2. from a design point of view, I don't see why a driver should know >>>> if >>>> a thermal zone is disabled or not >>>> >>>> It would make sense to end with this function and do not give the >>>> different drivers an opportunity to access this information. >>> >>> I agree. >>>> >>>> Why not add change_mode for the acpi in order to enable or disable >>>> the >>>> events >>> >>> thermal_zone_device_is_enabled() is invoked in acpi thermal driver >>> because we only want to do thermal_zone_device_update() when the acpi >>> thermal zone is enabled. >>> >>> As thermal_zone_device_update() can handle a disabled thermal zone now, >>> we can just remove the check. >> >> Ah yes, good point! >> >> >> > > I sent a short series with fixes. Daniel, can you kindly test it? I confirm the i.MX is now correctly booting with the thermal zone temperature available. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog