From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Magnus Damm <magnus.damm@gmail.com>,
Alexandru Ardelean <aardelean@deviqon.com>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v3 2/3] iio: adc: Add driver for Renesas RZ/G2L A/D converter
Date: Tue, 27 Jul 2021 09:54:20 +0100 [thread overview]
Message-ID: <CA+V-a8uKe=F_6pEdOkAXG_JitiQ8T9D_d0MDuKXHoo2XvXK=HQ@mail.gmail.com> (raw)
In-Reply-To: <145309b88353d4127c659dfabd374252cb2afc48.camel@pengutronix.de>
Hi Philipp,
On Tue, Jul 27, 2021 at 9:13 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> On Tue, 2021-07-27 at 09:02 +0100, Lad, Prabhakar wrote:
> [...]
> > > > + ret = devm_add_action_or_reset(&pdev->dev,
> > > > + rzg2l_adc_reset_assert, adc->adrstn);
> > > > + if (ret) {
> > > > + dev_err(&pdev->dev, "failed to register adrstn assert devm action, %d\n",
> > > > + ret);
> > > > + return ret;
> > > > + }
> > >
> > > This is the wrong way around. Installing devres actions should be done
> > > after the thing they are supposed to revert in case of error. You should
> > > move this down below the reset_control_deassert(adc->adrstn).
> > >
> > Ouch my understanding was, there won't be any harm in asserting the
> > reset line. Agree with will move this below
> > reset_control_deassert(adc->adrstn).
>
> You are probably right, but it's still better do it correctly. Just
> imagine one of the reset lines turns out to be shared later, or somebody
> else will look at this driver for inspiration.
>
Agreed, will do it the right way!
Cheers,
Prabhakar
next prev parent reply other threads:[~2021-07-27 8:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 18:28 [PATCH v3 0/3] Renesas RZ/G2L ADC driver support Lad Prabhakar
2021-07-26 18:28 ` [PATCH v3 1/3] dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L A/D converter Lad Prabhakar
2021-07-26 21:42 ` Rob Herring
2021-07-27 8:06 ` Lad, Prabhakar
2021-07-27 20:30 ` Rob Herring
2021-07-26 18:28 ` [PATCH v3 2/3] iio: adc: Add driver " Lad Prabhakar
2021-07-27 7:13 ` Philipp Zabel
2021-07-27 8:02 ` Lad, Prabhakar
2021-07-27 8:13 ` Philipp Zabel
2021-07-27 8:54 ` Lad, Prabhakar [this message]
2021-07-31 17:11 ` Jonathan Cameron
2021-07-31 18:31 ` Lad, Prabhakar
2021-08-01 16:59 ` Jonathan Cameron
2021-08-01 19:51 ` Lad, Prabhakar
2021-07-26 18:28 ` [PATCH v3 3/3] arm64: dts: renesas: r9a07g044: Add ADC node Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+V-a8uKe=F_6pEdOkAXG_JitiQ8T9D_d0MDuKXHoo2XvXK=HQ@mail.gmail.com' \
--to=prabhakar.csengg@gmail.com \
--cc=aardelean@deviqon.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).