From: Rob Herring <robh@kernel.org>
To: Alex Helms <alexander.helms.jy@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
"open list:MEDIA DRIVERS FOR RENESAS - FCP"
<linux-renesas-soc@vger.kernel.org>,
david.cater.jc@renesas.com, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: Add binding for Renesas 8T49N241
Date: Thu, 22 Jul 2021 08:19:47 -0600 [thread overview]
Message-ID: <CAL_Jsq+2tpjNffzNPDa2XSZWAk3B-HS-bF7EmZ_j0t_=nfEWvg@mail.gmail.com> (raw)
In-Reply-To: <6fbb307e-8835-224e-7912-2b956985a713@renesas.com>
On Tue, Jul 20, 2021 at 10:58 AM Alex Helms
<alexander.helms.jy@renesas.com> wrote:
>
> On 7/19/2021 3:48 PM, Rob Herring wrote:
> > On Mon, 19 Jul 2021 11:20:00 -0700, Alex Helms wrote:
> >> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> >> The 8T49N241 accepts up to two differential or single-ended input clocks
> >> and a fundamental-mode crystal input. The internal PLL can lock to either
> >> of the input reference clocks or to the crystal to behave as a frequency
> >> synthesizer.
> >>
> >> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
> >> ---
> >> .../bindings/clock/renesas,8t49n241.yaml | 190 ++++++++++++++++++
> >> MAINTAINERS | 6 +
> >> 2 files changed, 196 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
> >>
> >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
> >
>
> Thank you for the info. I'm new to the kernel process and appreciate your advice.
>
> I felt uncomfortable adding your Reviewed-By tag but since there were no changes to the dt
> portion of the patch, in retrospect I guess I should have added it. I'll keep this in mind
> for the future. Is there anything I need to do for this patch?
For v5, no. If there's a v6 posted, then add any tags.
Rob
next prev parent reply other threads:[~2021-07-22 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 18:19 [PATCH v5 0/2] Renesas 8T49N241 device driver Alex Helms
2021-07-19 18:20 ` [PATCH v5 1/2] dt-bindings: Add binding for Renesas 8T49N241 Alex Helms
2021-07-19 22:48 ` Rob Herring
2021-07-20 16:58 ` Alex Helms
2021-07-22 14:19 ` Rob Herring [this message]
2021-07-19 18:20 ` [PATCH v5 2/2] clk: Add ccf driver " Alex Helms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+2tpjNffzNPDa2XSZWAk3B-HS-bF7EmZ_j0t_=nfEWvg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alexander.helms.jy@renesas.com \
--cc=david.cater.jc@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).