From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
USB list <linux-usb@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/4] usb: host: xhci-plat: add quirks member into struct xhci_plat_priv
Date: Tue, 27 Aug 2019 14:35:39 +0200 [thread overview]
Message-ID: <CAMuHMdW4xa=RFqUdCEs1v3MuqAFwpXoW=tvcdEocqe3eeCpd=Q@mail.gmail.com> (raw)
In-Reply-To: <1566900127-11148-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hi Shimoda-san,
On Tue, Aug 27, 2019 at 12:05 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> To simplify adding xhci->quirks instead of the .init_quirk()
> function, this patch adds a new parameter "quirks" into
> the struct xhci_plat_priv.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/usb/host/xhci-plat.h
> +++ b/drivers/usb/host/xhci-plat.h
> @@ -12,10 +12,12 @@
>
> struct xhci_plat_priv {
> const char *firmware_name;
> + unsigned long long quirks;
> void (*plat_start)(struct usb_hcd *);
> int (*init_quirk)(struct usb_hcd *);
> int (*resume_quirk)(struct usb_hcd *);
> };
>
> #define hcd_to_xhci_priv(h) ((struct xhci_plat_priv *)hcd_to_xhci(h)->priv)
> +#define xhci_to_priv(x) ((struct xhci_plat_priv *)(x)->priv)
Just wondering: is x->priv guaranteed to be of type struct xhci_plat_priv *,
also in the future?
struct xhci_hcd {
...
unsigned long priv[0] __aligned(sizeof(s64));
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-08-27 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 10:02 [PATCH 0/4] usb: host: xhci-{plat,rcar}: clean up and add a workaround Yoshihiro Shimoda
2019-08-27 10:02 ` [PATCH 1/4] usb: host: xhci-plat: add quirks member into struct xhci_plat_priv Yoshihiro Shimoda
2019-08-27 12:35 ` Geert Uytterhoeven [this message]
2019-08-28 4:05 ` Yoshihiro Shimoda
2019-08-28 7:08 ` Geert Uytterhoeven
2019-08-27 10:02 ` [PATCH 2/4] usb: host: xhci-rcar: Add a helper macro to set xhci_plat_priv Yoshihiro Shimoda
2019-08-27 12:36 ` Geert Uytterhoeven
2019-08-27 10:02 ` [PATCH 3/4] usb: host: xhci-rcar: Use xhci_plat_priv.quirks instead of code settings Yoshihiro Shimoda
2019-08-27 12:42 ` Geert Uytterhoeven
2019-08-27 10:02 ` [PATCH 4/4] usb: host: xhci-rcar: avoid 60s wait by request_firmware() in system booting Yoshihiro Shimoda
2019-08-31 8:43 ` Simon Horman
2019-09-02 10:35 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdW4xa=RFqUdCEs1v3MuqAFwpXoW=tvcdEocqe3eeCpd=Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).