linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
Date: Tue, 4 Feb 2020 20:44:36 +0100	[thread overview]
Message-ID: <CAMuHMdW7SX2W5LXvBMgTMXcjsM8bz5nhBBD=DzwLaiA4Xq3e7A@mail.gmail.com> (raw)
In-Reply-To: <20200204193050.GN10400@smile.fi.intel.com>

Hi Andy,

On Tue, Feb 4, 2020 at 8:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> > On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > > Replace with appropriate types.h.
> > >
> > > Thanks for your patch!
> > >
> > > I have only one very short question: why?
> >
> > Likewise :-) The patch itself looks fine, but the commit message is a
> > bit terse.
>
> The kernel.h for a long time being a dump of a lot of things. I started
> cleaning it up a bit. During this I notice that developers too far too lazy to
> use appropriate headers. For platform data kernel.h by definition is not
> appropriate.

Thanks, that makes perfect sense.

> Any suggestion what should I put to commit message?

I became intrigued by the one-line summary, which seemed to suggest
(according to my interpretation) that including kernel.h is a Real Bad
Thing.

But basically all you wanted to say was:

    drm: shmobile: Reduce include dependencies

and:

    This file doesn't need everything provided by <linux/kernel.h>.
    All it needs are some types, which are provided by <linux/types.h>.

Right?

BTW, <drm/drm_mode.h> already includes <linux/types.h>, but not relying
on implicit includes is indeed a good thing.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2020-02-04 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 16:19 [PATCH v1] drm: shmobile: Platform data shan't include kernel.h Andy Shevchenko
2020-02-04 17:39 ` Geert Uytterhoeven
2020-02-04 18:26   ` Laurent Pinchart
2020-02-04 19:30     ` Andy Shevchenko
2020-02-04 19:44       ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdW7SX2W5LXvBMgTMXcjsM8bz5nhBBD=DzwLaiA4Xq3e7A@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).