From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C85BC004C9 for ; Tue, 7 May 2019 16:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 742CA205C9 for ; Tue, 7 May 2019 16:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbfEGQc6 (ORCPT ); Tue, 7 May 2019 12:32:58 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:32893 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbfEGQc6 (ORCPT ); Tue, 7 May 2019 12:32:58 -0400 Received: by mail-vs1-f68.google.com with SMTP id z145so10797982vsc.0; Tue, 07 May 2019 09:32:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xfZ+nPfJalivsFUof8XfkbfxeRXadcob2dPu22J78FE=; b=fXgkkodcnkRkgqOKPo7Lo23rHK9gmlTUyDkeg8WbYvjt/AmJJTseE8R446j9Ibxr3K eTv9g9c2TMbp8916ViJXf8vs0VKRiVXjkzkrdii+/HiFcoxWsnlohQh0re3RcIpKxeb5 SfX8F9KBw0whfZMsDqbazwNBBaN7HYIfFDgd0qj26zZw3hY1sg+pY/D4xdVovmWyvg85 oHhrpXFw3wOBVmWPWGgs3r/7IHhWaPiX4jkBCJpgflDhXakQcKaoHAkgGnVmxQeYy7kA /sn79S8T02Cu65B2f5ZhCF5B/mREmgHsRLie3fLPE+giL5HseVMmapLi3oVNaHmt4E2V R+Fw== X-Gm-Message-State: APjAAAUqlm+y6FuIXWwdFJbO+TdYYepo7tdk/hNchdZ9DPiwzA8y1mkW VCTNWYoQNWshLoRxaq6zK/Elo8r65jA7que6tME= X-Google-Smtp-Source: APXvYqwnBOm/31+1n0uOIej23iQ7zEwFHV7MPPxuNGseA0JkCWZ9jKf5bC8Pf3dai9+n75aDdCcSS3EpAwX0z+b1ukA= X-Received: by 2002:a67:ba07:: with SMTP id l7mr16617093vsn.11.1557246776403; Tue, 07 May 2019 09:32:56 -0700 (PDT) MIME-Version: 1.0 References: <20190506234631.113226-1-chris.brandt@renesas.com> <20190506234631.113226-2-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 7 May 2019 18:32:44 +0200 Message-ID: Subject: Re: [PATCH 01/10] phy: renesas: rcar-gen3-usb2: Add uses_usb_x1 option To: Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Chris, On Tue, May 7, 2019 at 5:43 PM Chris Brandt wrote: > On Tue, May 07, 2019, Geert Uytterhoeven wrote: > > > + if (of_property_read_bool(dev->of_node, "renesas,uses_usb_x1")) > > > + channel->uses_usb_x1 = true; > > > + > > > > Perhaps this can be checked some other way (e.g. by checking for a non- > > zero > > clock rate of the USB_X1 clock referenced from DT), thus removing the need > > for > > adding a custom property? > > Currently, there is no USB_X1 in DT like there is for RZ/A1. > > For RZ/A2, those are dedicated pins that belong to the USB HW block > itself. They do not feed into the system CPG or any dividers, so I > never included it in the .dtsi. Like pcie_bus_clk on R-Car? We do have that in DT, with a "clock" link to it from the PCIe device node. After all, it is provided by an external clock crystal, and consumed by the PCIe device. > So with that said, does a uses-usb-x1 property make more sense? No ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds