From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: Re: [PATCH v2 1/4] pinctrl: renesas: r8a77951: Add vin{4,5}_high8 pins
Date: Tue, 9 Mar 2021 09:26:33 +0100 [thread overview]
Message-ID: <CAMuHMdWpCSkeogU-kkc_=OYyvtuMim3yAB4AvF0sKUew1=bRsA@mail.gmail.com> (raw)
In-Reply-To: <20210308155942.1733341-2-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
On Mon, Mar 8, 2021 at 5:00 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds VIN{4,5}_high8 support to the R8A77951 SoC.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> * Changes since v1
> - Rename g8 to high8 per Geerts suggestion.
> - Rebase to renesas-pinctrl.
Thanks for the update!
> --- a/drivers/pinctrl/renesas/pfc-r8a77951.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a77951.c
> @@ -4126,6 +4126,18 @@ static const union vin_data vin4_data_b_mux = {
> VI4_DATA22_MARK, VI4_DATA23_MARK,
> },
> };
> +static const unsigned int vin4_high8_pins[] = {
> + RCAR_GP_PIN(1, 0), RCAR_GP_PIN(1, 1),
> + RCAR_GP_PIN(1, 2), RCAR_GP_PIN(1, 3),
> + RCAR_GP_PIN(1, 4), RCAR_GP_PIN(1, 5),
> + RCAR_GP_PIN(1, 6), RCAR_GP_PIN(1, 7),
> +};
> +static const unsigned int vin4_high8_mux[] = {
> + VI4_DATA8_MARK, VI4_DATA9_MARK,
> + VI4_DATA10_MARK, VI4_DATA11_MARK,
> + VI4_DATA12_MARK, VI4_DATA13_MARK,
> + VI4_DATA14_MARK, VI4_DATA15_MARK,
> +};
I think for vin4, you should keep on calling them "vin4_g8", as vin4
supports 24-bit RGB, and "high8" would mean lines 16-23, not 8-15.
Same comment for the other patches, obviously.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-03-09 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 15:59 [PATCH v2 0/4] pinctrl: renesas: Add vin{4,5}_high8 pins Niklas Söderlund
2021-03-08 15:59 ` [PATCH v2 1/4] pinctrl: renesas: r8a77951: " Niklas Söderlund
2021-03-09 8:26 ` Geert Uytterhoeven [this message]
2021-03-08 15:59 ` [PATCH v2 2/4] pinctrl: renesas: r8a7796: " Niklas Söderlund
2021-03-08 15:59 ` [PATCH v2 3/4] pinctrl: renesas: r8a77990: " Niklas Söderlund
2021-03-08 15:59 ` [PATCH v2 4/4] pinctrl: renesas: r8a77965: " Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWpCSkeogU-kkc_=OYyvtuMim3yAB4AvF0sKUew1=bRsA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).