From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Marian-Cristian Rotariu
<marian-cristian.rotariu.rb@bp.renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Simon Horman <horms@verge.net.au>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Fix EXTAL Clock frequency
Date: Fri, 20 Dec 2019 17:04:07 +0100 [thread overview]
Message-ID: <CAMuHMdX71dO803qY+GyYx5Dz+miat3f=NCOFc8aBn_pmqe5Zog@mail.gmail.com> (raw)
In-Reply-To: <1576667617-35615-1-git-send-email-biju.das@bp.renesas.com>
Hi Biju,
On Wed, Dec 18, 2019 at 12:15 PM Biju Das <biju.das@bp.renesas.com> wrote:
> As per the schematic, the extal frequency is 16.6666MHz. However
> it is wrongly mentioned as 16666666 on the SoC dtsi.
>
> Fixes: 438419ebd3f86221390 ("arm64: dts: renesas: Add HiHope RZ/G2M
> main board support")
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -154,7 +154,7 @@
> };
>
> &extal_clk {
> - clock-frequency = <16666666>;
> + clock-frequency = <16666600>;
> };
Given the schematics say the accuracy of the part is specified as 50ppm[*],
changing this doesn't matter much, IMHO.
[*] Yeah, that's more than 4s/day, so it would made a lousy watch, if not
for NTP ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-12-20 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 11:13 [PATCH] arm64: dts: renesas: hihope-common: Fix EXTAL Clock frequency Biju Das
2019-12-20 16:04 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdX71dO803qY+GyYx5Dz+miat3f=NCOFc8aBn_pmqe5Zog@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marian-cristian.rotariu.rb@bp.renesas.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).