From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9124DC4338F for ; Tue, 10 Aug 2021 10:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F94E6108F for ; Tue, 10 Aug 2021 10:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237928AbhHJKUc (ORCPT ); Tue, 10 Aug 2021 06:20:32 -0400 Received: from mail-vs1-f44.google.com ([209.85.217.44]:34709 "EHLO mail-vs1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238900AbhHJKUb (ORCPT ); Tue, 10 Aug 2021 06:20:31 -0400 Received: by mail-vs1-f44.google.com with SMTP id y1so12007713vsc.1; Tue, 10 Aug 2021 03:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ViSXR6yXK8nsqcEj3nqGncGWwhL5obzmTb+wOi66chs=; b=EV4S8Pu33fNwapCwclrDr8O/IQ63wO3ZnlPG+XueAKNm1palHCtY3+Qk+w1SbrBT6z QL6kjWtlSUcXJrAWL4MPIQ7lL4Pk6EnbVNLuE2ATdIjF0zuvND5Vk6oEFs4f+eCQbbJj d3nKks+ZLA7s1b6Jdr56CxyPoF+dhNg8RzIP3MPkhxSaljYLm9NoB+Lazfn41PNrvigl hjHAkuvHBgku4gvDiJ1XPtKZ3hSlReNp2dYJTYj5UazAfhqZ6uhVJ3/ezVJSvzuT7FxP oybQszDQy5/2GfouF4PP+du69jd4F2o5e2aJt9s1c9czRMVQSII0kGxz801Fk6W3/OeH xY+Q== X-Gm-Message-State: AOAM532h86cuLEQ7xt9n0OauE5IQX6YYThFQ+qQYqp0FQC+xqPGMiN9K WBxz/F1BpEStN8POkGdMeNhmUv/iw2oG3hqte7s= X-Google-Smtp-Source: ABdhPJyOj4tbjccYcMl81/wp6Mmxp3+Qc6KXndH2R/c2o5BHeaS5HPmc1utV+HCZCUWiuQaRQce+ScpO+478z+yngUA= X-Received: by 2002:a67:e2c7:: with SMTP id i7mr20171647vsm.3.1628590809393; Tue, 10 Aug 2021 03:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20210727185527.19907-1-biju.das.jz@bp.renesas.com> <20210727185527.19907-5-biju.das.jz@bp.renesas.com> In-Reply-To: <20210727185527.19907-5-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Tue, 10 Aug 2021 12:19:58 +0200 Message-ID: Subject: Re: [PATCH v5 4/6] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support To: Biju Das Cc: Rob Herring , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Biju Das , Prabhakar Mahadev Lad Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Biju, On Tue, Jul 27, 2021 at 8:55 PM Biju Das wrote: > Add USB2.0 phy and host support to SoC DT. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > @@ -200,6 +200,100 @@ > <0x0 0x11940000 0 0x60000>; > interrupts = ; > }; > + > + phyrst: usbphy-ctrl@11c40000 { > + compatible = "renesas,r9a07g044-usbphy-ctrl", > + "renesas,rzg2l-usbphy-ctrl"; > + reg = <0 0x11c40000 0 0x10000>; > + clocks = <&cpg CPG_MOD R9A07G044_USB_PCLK>; > + resets = <&cpg R9A07G044_USB_PRESETN>; > + power-domains = <&cpg>; > + #reset-cells = <1>; Should there be a status = "disabled"? > + }; The rest looks good to me, so with the above clarified: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds