From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
kbuild-all@01.org
Subject: Re: [renesas-drivers:clk-renesas-for-v5.1 6/7] drivers/clk/renesas/rcar-gen3-cpg.c:472:42-45: ERROR: reference preceded by free on line 470 (fwd)
Date: Thu, 31 Jan 2019 08:52:59 +0100 [thread overview]
Message-ID: <CAMuHMdXUVy+WROFLx1y0Sp9iO=Xi-AAzQJRjLzFH9TNqp5Mt3w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1901310710350.2693@hadrien>
Hi Julia,
On Thu, Jan 31, 2019 at 7:11 AM Julia Lawall <julia.lawall@lip6.fr> wrote:
> I guess that a return is missing after line 470.
Thank you, indeed.
I will fix it up in clk-renesas-for-v5.1, as no pull request has been sent
for that branch yet.
> ---------- Forwarded message ----------
> Date: Thu, 31 Jan 2019 10:08:10 +0800
> From: kbuild test robot <lkp@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: [renesas-drivers:clk-renesas-for-v5.1 6/7]
> drivers/clk/renesas/rcar-gen3-cpg.c:472:42-45: ERROR: reference preceded by
> free on line 470
>
> CC: kbuild-all@01.org
> CC: linux-renesas-soc@vger.kernel.org
> TO: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> CC: Geert Uytterhoeven <geert+renesas@glider.be>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git clk-renesas-for-v5.1
> head: 5f8c668738ae4bcfe0656e74127610aabd5d5141
> commit: ac41e5750e7508c170b6a1d9d623c4caa4c0fbf6 [6/7] clk: renesas: rcar-gen3: Add RPC clocks
> :::::: branch date: 6 days ago
> :::::: commit date: 6 days ago
>
> >> drivers/clk/renesas/rcar-gen3-cpg.c:472:42-45: ERROR: reference preceded by free on line 470
>
> # https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?id=ac41e5750e7508c170b6a1d9d623c4caa4c0fbf6
> git remote add renesas-drivers https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> git remote update renesas-drivers
> git checkout ac41e5750e7508c170b6a1d9d623c4caa4c0fbf6
> vim +472 drivers/clk/renesas/rcar-gen3-cpg.c
>
> ac41e575 Sergei Shtylyov 2019-01-22 442
> ac41e575 Sergei Shtylyov 2019-01-22 443 static struct clk * __init cpg_rpc_clk_register(const char *name,
> ac41e575 Sergei Shtylyov 2019-01-22 444 void __iomem *base, const char *parent_name,
> ac41e575 Sergei Shtylyov 2019-01-22 445 struct raw_notifier_head *notifiers)
> ac41e575 Sergei Shtylyov 2019-01-22 446 {
> ac41e575 Sergei Shtylyov 2019-01-22 447 struct rpc_clock *rpc;
> ac41e575 Sergei Shtylyov 2019-01-22 448 struct clk *clk;
> ac41e575 Sergei Shtylyov 2019-01-22 449
> ac41e575 Sergei Shtylyov 2019-01-22 450 rpc = kzalloc(sizeof(*rpc), GFP_KERNEL);
> ac41e575 Sergei Shtylyov 2019-01-22 451 if (!rpc)
> ac41e575 Sergei Shtylyov 2019-01-22 452 return ERR_PTR(-ENOMEM);
> ac41e575 Sergei Shtylyov 2019-01-22 453
> ac41e575 Sergei Shtylyov 2019-01-22 454 rpc->div.reg = base + CPG_RPCCKCR;
> ac41e575 Sergei Shtylyov 2019-01-22 455 rpc->div.width = 3;
> ac41e575 Sergei Shtylyov 2019-01-22 456 rpc->div.table = cpg_rpc_div_table;
> ac41e575 Sergei Shtylyov 2019-01-22 457 rpc->div.lock = &cpg_lock;
> ac41e575 Sergei Shtylyov 2019-01-22 458
> ac41e575 Sergei Shtylyov 2019-01-22 459 rpc->gate.reg = base + CPG_RPCCKCR;
> ac41e575 Sergei Shtylyov 2019-01-22 460 rpc->gate.bit_idx = 8;
> ac41e575 Sergei Shtylyov 2019-01-22 461 rpc->gate.flags = CLK_GATE_SET_TO_DISABLE;
> ac41e575 Sergei Shtylyov 2019-01-22 462 rpc->gate.lock = &cpg_lock;
> ac41e575 Sergei Shtylyov 2019-01-22 463
> ac41e575 Sergei Shtylyov 2019-01-22 464 rpc->csn.reg = base + CPG_RPCCKCR;
> ac41e575 Sergei Shtylyov 2019-01-22 465
> ac41e575 Sergei Shtylyov 2019-01-22 466 clk = clk_register_composite(NULL, name, &parent_name, 1, NULL, NULL,
> ac41e575 Sergei Shtylyov 2019-01-22 467 &rpc->div.hw, &clk_divider_ops,
> ac41e575 Sergei Shtylyov 2019-01-22 468 &rpc->gate.hw, &clk_gate_ops, 0);
> ac41e575 Sergei Shtylyov 2019-01-22 469 if (IS_ERR(clk))
> ac41e575 Sergei Shtylyov 2019-01-22 @470 kfree(rpc);
> ac41e575 Sergei Shtylyov 2019-01-22 471
> ac41e575 Sergei Shtylyov 2019-01-22 @472 cpg_simple_notifier_register(notifiers, &rpc->csn);
> ac41e575 Sergei Shtylyov 2019-01-22 473 return clk;
> ac41e575 Sergei Shtylyov 2019-01-22 474 }
> ac41e575 Sergei Shtylyov 2019-01-22 475
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-01-31 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 6:11 [renesas-drivers:clk-renesas-for-v5.1 6/7] drivers/clk/renesas/rcar-gen3-cpg.c:472:42-45: ERROR: reference preceded by free on line 470 (fwd) Julia Lawall
2019-01-31 7:52 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXUVy+WROFLx1y0Sp9iO=Xi-AAzQJRjLzFH9TNqp5Mt3w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=geert+renesas@glider.be \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).