From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
Date: Fri, 23 Jul 2021 15:52:13 +0000 [thread overview]
Message-ID: <OS0PR01MB592299E2554B073C582F29BE86E59@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWMB8o=GuvOtzBg6w6m3C030wu7-btT+FJ-dAZgNK3xsQ@mail.gmail.com>
Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
>
> Hi Biju,
>
> On Wed, Jul 21, 2021 at 8:06 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Hihope boards use Realtek PHY. From the very beginning it use only tx
> > delays. However the phy driver commit bbc4d71d63549bcd003
> > ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced NFS
> > mount failure. Now it needs rx delay inaddition to tx delay for NFS
> > mount to work. This patch fixes NFS mount failure issue by adding MAC
> > internal rx delay.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
> in renesas-devel for v5.15.
>
> Do you want a Fixes: tag?
It is a tricky situation. The phy patch is introduced in 5.9 and is backported to 5.8.
But we don't have MaC internal delays on those kernels. So Fixes for 5.10+ will be ok I guess,
So that at least this fix will land on cip 5.10 kernel.
Regards,
Biju
>
> > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > @@ -20,6 +20,7 @@
> > pinctrl-names = "default";
> > phy-handle = <&phy0>;
> > tx-internal-delay-ps = <2000>;
> > + rx-internal-delay-ps = <1800>;
> > status = "okay";
> >
> > phy0: ethernet-phy@0 {
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2021-07-23 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 18:06 [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay Biju Das
2021-07-23 15:22 ` Geert Uytterhoeven
2021-07-23 15:52 ` Biju Das [this message]
2021-07-23 16:00 ` Geert Uytterhoeven
2021-07-23 16:08 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB592299E2554B073C582F29BE86E59@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).