From: "ashiduka@fujitsu.com" <ashiduka@fujitsu.com>
To: 'Sergei Shtylyov' <sergei.shtylyov@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done
Date: Thu, 6 Aug 2020 02:28:36 +0000 [thread overview]
Message-ID: <OSAPR01MB384402DF70DE090C10BAB4F8DF480@OSAPR01MB3844.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <0e7d72fe-ea70-612c-7a50-ad1ff905ddf4@gmail.com>
Hi Sergei,
> CCing DaveM (as you should have done from the start)...
Thank you. I appreciate your help.
> Did you also build mdio-bitbang.c as a module?
Yes. Sure.
> For the in-kernal driver, not being able to rmmod the 'ravb' one sounds
> logical. :-)
root@rcar-gen3:~# lsmod|grep ravb
ravb 40960 1
mdio_bitbang 16384 1 ravb
root@rcar-gen3:~# modprobe -r ravb
modprobe: FATAL: Module ravb is in use.
root@rcar-gen3:~# modprobe -r mdio_bitbang
modprobe: FATAL: Module mdio_bitbang is in use.
>> Fixed to execute mdio_init() at open and free_mdio() at close, thereby rmmod is
> Call ravb_mdio_init() at open and free_mdio_bitbang() at close.
OK.
Include the exact function name in the commit log, not the abbreviated function name.
> Dave, would you tolerate the forward declarations here instead (to avoid the function moves, to be later
> done in the net-next tree)?
Wait for Dave's reply for a while.
(If Dave's reply is slow, I will only correct Sergei's issue and post it)
Thanks & Best Regards,
Yuusuke Ashizuka <ashiduka@fujitsu.com>
prev parent reply other threads:[~2020-08-06 2:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 3:56 [PATCH] ravb: Fixed the problem that rmmod can not be done Yuusuke Ashizuka
2020-07-30 7:55 ` kernel test robot
2020-07-30 10:01 ` [PATCH v2] " Yuusuke Ashizuka
2020-07-30 11:37 ` Yoshihiro Shimoda
2020-07-30 16:24 ` Sergei Shtylyov
2020-07-31 6:43 ` Yoshihiro Shimoda
2020-07-31 17:45 ` Sergei Shtylyov
2020-07-30 16:04 ` Sergei Shtylyov
2020-07-31 10:18 ` ashiduka
2020-07-31 16:28 ` Sergei Shtylyov
2020-08-06 2:26 ` ashiduka
2020-07-31 18:32 ` Sergei Shtylyov
2020-08-06 2:28 ` ashiduka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB384402DF70DE090C10BAB4F8DF480@OSAPR01MB3844.jpnprd01.prod.outlook.com \
--to=ashiduka@fujitsu.com \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).