From: Biju Das <biju.das@bp.renesas.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: RE: [PATCH v2] phy: renesas: phy-rcar-gen2: Fix the array off by one warning
Date: Wed, 9 Oct 2019 13:01:20 +0000 [thread overview]
Message-ID: <OSBPR01MB210328C4D1CB0573B689888DB8950@OSBPR01MB2103.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <8ecdceea-a698-7f6a-7a33-4684b9e139c6@ti.com>
Hi Kishon,
Thanks for the feedback
> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@ti.com>
> Sent: Wednesday, October 9, 2019 1:55 PM
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>; Wolfram Sang
> <wsa+renesas@sang-engineering.com>; Simon Horman
> <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>;
> Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; linux-renesas-soc@vger.kernel.org;
> Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Subject: Re: [PATCH v2] phy: renesas: phy-rcar-gen2: Fix the array off by one
> warning
>
> Hi Biju,
>
> On 01/10/19 12:09 PM, Biju Das wrote:
> > Hello Kishon,
> >
> > Are you happy with this patch? Please let me know.
> >
> > https://patchwork.kernel.org/patch/10946601/
>
>
> Can you resend the patch with the updated tags please?
>
Yes. Will do
Regards,
Biju
> >
> >
> > Regards,
> > Biju
> >
> >> Subject: RE: [PATCH v2] phy: renesas: phy-rcar-gen2: Fix the array
> >> off by one warning
> >>
> >> Hi Biju-san,
> >>
> >>> From: Biju Das, Sent: Thursday, May 16, 2019 10:22 PM
> >>>
> >>> Fix the below smatch warning by adding variable check rather than
> >>> the hardcoded value.
> >>> warn: array off by one? 'data->select_value[channel_num]'
> >>>
> >>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>
> >> Thank you for the patch!
> >>
> >> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >>
> >> Best regards,
> >> Yoshihiro Shimoda
> >
prev parent reply other threads:[~2019-10-09 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 13:22 [PATCH v2] phy: renesas: phy-rcar-gen2: Fix the array off by one warning Biju Das
2019-05-16 13:51 ` Wolfram Sang
2019-05-17 13:25 ` Ulrich Hecht
2019-05-21 7:03 ` Yoshihiro Shimoda
2019-10-01 6:39 ` Biju Das
2019-10-09 12:54 ` Kishon Vijay Abraham I
2019-10-09 13:01 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB210328C4D1CB0573B689888DB8950@OSBPR01MB2103.jpnprd01.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=horms@verge.net.au \
--cc=kishon@ti.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).