From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Linux PWM List <linux-pwm@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 4/4] pwm: rcar: improve calculation of divider
Date: Tue, 8 Jan 2019 09:30:38 +0000 [thread overview]
Message-ID: <TY2PR01MB4812A3D8A3E8A2938F147E71D88A0@TY2PR01MB4812.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVZXjFoY7J-1_WfL3xz1cO5XUEi8YnFK9W8gGfMdLDnhw@mail.gmail.com>
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Tuesday, January 8, 2019 5:22 PM
>
> Hi Shimoda-san,
>
> On Tue, Jan 8, 2019 at 4:31 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > The rcar_pwm_get_clock_division() has a loop to calculate the divider,
> > but the value of div should be calculatable without a loop. So,
> > this patch improves it.
> >
> > This algorithm is suggested by Uwe Kleine-König and Laurent Pinchart.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> > drivers/pwm/pwm-rcar.c | 16 +++++++---------
> > 1 file changed, 7 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c
> > index 6dbb70c..0498a93 100644
> > --- a/drivers/pwm/pwm-rcar.c
> > +++ b/drivers/pwm/pwm-rcar.c
> > @@ -8,6 +8,8 @@
> > #include <linux/clk.h>
> > #include <linux/err.h>
> > #include <linux/io.h>
> > +#include <linux/log2.h>
> > +#include <linux/math64.h>
> > #include <linux/module.h>
> > #include <linux/of.h>
> > #include <linux/platform_device.h>
> > @@ -68,19 +70,15 @@ static void rcar_pwm_update(struct rcar_pwm_chip *rp, u32 mask, u32 data,
> > static int rcar_pwm_get_clock_division(struct rcar_pwm_chip *rp, int period_ns)
> > {
> > unsigned long clk_rate = clk_get_rate(rp->clk);
> > - unsigned long long max; /* max cycle / nanoseconds */
> > - unsigned int div;
> > + u64 div, tmp;
> >
> > if (clk_rate == 0)
> > return -EINVAL;
> >
> > - for (div = 0; div <= RCAR_PWM_MAX_DIVISION; div++) {
> > - max = (unsigned long long)NSEC_PER_SEC * RCAR_PWM_MAX_CYCLE *
> > - (1 << div);
> > - do_div(max, clk_rate);
> > - if (period_ns <= max)
> > - break;
> > - }
> > + div = NSEC_PER_SEC * RCAR_PWM_MAX_CYCLE;
>
> As we have:
>
> #define NSEC_PER_SEC 1000000000L
> #define RCAR_PWM_MAX_CYCLE 1023
>
> NSEC_PER_SEC is 64-bit on arm64, and 32-bit on arm32.
>
> Hence you should use
>
> div = (u64)NSEC_PER_SEC * RCAR_PWM_MAX_CYCLE;
>
> to avoid overflow on arm32.
Thank you for the comment! I'll fix this.
Best regards,
Yoshihiro Shimoda
> > + tmp = (u64)period_ns * clk_rate + div - 1;
> > + tmp = div64_u64(tmp, div);
> > + div = ilog2(tmp - 1) + 1;
> >
> > return (div <= RCAR_PWM_MAX_DIVISION) ? div : -ERANGE;
> > }
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
prev parent reply other threads:[~2019-01-08 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 3:28 [PATCH v2 0/4] pwm: rcar: Add support "atomic" API and improve calculation Yoshihiro Shimoda
2019-01-08 3:28 ` [PATCH v2 1/4] pwm: rcar: Add support "atomic" API Yoshihiro Shimoda
2019-01-08 7:43 ` Uwe Kleine-König
2019-01-08 8:11 ` Yoshihiro Shimoda
2019-01-08 3:28 ` [PATCH v2 2/4] pwm: rcar: Use "atomic" API on rcar_pwm_resume() Yoshihiro Shimoda
2019-01-08 7:47 ` Uwe Kleine-König
2019-01-08 8:46 ` Yoshihiro Shimoda
2019-01-08 9:12 ` Uwe Kleine-König
2019-01-08 8:56 ` Geert Uytterhoeven
2019-01-08 9:19 ` Uwe Kleine-König
2019-01-08 9:35 ` Geert Uytterhoeven
2019-01-10 9:51 ` Uwe Kleine-König
2019-01-08 3:28 ` [PATCH v2 3/4] pwm: rcar: remove legacy APIs Yoshihiro Shimoda
2019-01-08 7:49 ` Uwe Kleine-König
2019-01-08 3:28 ` [PATCH v2 4/4] pwm: rcar: improve calculation of divider Yoshihiro Shimoda
2019-01-08 7:49 ` Uwe Kleine-König
2019-01-08 8:21 ` Geert Uytterhoeven
2019-01-08 9:30 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY2PR01MB4812A3D8A3E8A2938F147E71D88A0@TY2PR01MB4812.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).