From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"REE erosca@DE.ADIT-JV.COM" <erosca@DE.ADIT-JV.COM>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: RE: [PATCH] pinctrl: sh-pfc: Split R-Car H3 support in two independent drivers
Date: Mon, 6 Jan 2020 08:20:01 +0000 [thread overview]
Message-ID: <TYAPR01MB4544C1FDB2791246DBDF46F7D83C0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVnoGpBvU5hH1dBHo6QXFS5voy6SmEDZKyu1JWqLfwhGQ@mail.gmail.com>
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Thursday, December 26, 2019 11:34 PM
<snip>
> > > Suggestions for simplifying sh_pfc_quirk_match(), or for alternative
> > > solutions are welcome!
> >
> > I wondered if using weak attribute on both info variables could
> > simplify sh_pfc_quirk_match(), but such a code [1] doesn't seem better
> > than using #ifdef. Also, using weak attributes waste data size
> > if R8A77950=n and R8A77951=y for instance.
>
> Thanks for the great suggestion!
>
> The trick is to add __weak to the existing extern declarations in sh_pfc.h,
> instead of adding weak empty structs.
> When the structs don't exist, their addresses just become zero.
I'm happy my suggestion is useful!
# I didn't know the trick though :)
> So I came up with the following (whitespace-damaged) patch, which I intend
> to fold into the original, if no one objects.
The v2 patch [1] is better than v1!
[1]
https://patchwork.kernel.org/patch/11312733/
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2020-01-06 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 18:42 [PATCH] pinctrl: sh-pfc: Split R-Car H3 support in two independent drivers Geert Uytterhoeven
2019-12-25 9:46 ` Yoshihiro Shimoda
2019-12-26 14:34 ` Geert Uytterhoeven
2020-01-06 8:20 ` Yoshihiro Shimoda [this message]
2020-01-06 8:25 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544C1FDB2791246DBDF46F7D83C0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=erosca@DE.ADIT-JV.COM \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).