From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH/RFC v2] mmc: host: renesas_sdhi: Refactor of_device_id.data
Date: Wed, 30 Jun 2021 06:41:35 +0200 [thread overview]
Message-ID: <YNv1/9WsdYu3ZwVv@ninjato> (raw)
In-Reply-To: <20210629102033.847369-1-yoshihiro.shimoda.uh@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]
Hi Shimoda-san,
thank you for taking care of this!
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reported-by: kernel test robot <lkp@intel.com>
I think this Rep-by can go. Test bot mentioned one build error of v1,
but it didn't report that we should refactor this code.
> -- should I make step-by-step patches to ease review?
I'd think this is good enough.
> -- should I rename the current renesas_sdhi_of_data (e.g. renesas_sdhi_param)?
> (renesas_sdhi_of_data and renesas_sdhi_of_data_with_quirks seem strange
> a little?)
Yes, this may be a little better. I'd think the current naming is good
enough, though.
> - I tested this patch on r8a77951 (ES3.0), r8a77960 (ES1.0) and r8a77965.
I also tested this on r8a77965.
> - Also I tested this patch on r8a7791 [2].
I'll check r8a7790 later.
> static const struct renesas_sdhi_quirks sdhi_quirks_r8a7796_es13 = {
> .hs400_4taps = true,
> .hs400_bad_taps = BIT(2) | BIT(3) | BIT(6) | BIT(7),
> .hs400_calib_table = r8a7796_es13_calib_table,
> };
You leave the quirk handling of different ES versions still in
renesas_sdhi_core. I'd think this should also be moved to
renesas_sdhi_internal_dmac? Then we have all the handling in one place.
> +static const struct renesas_sdhi_of_data_with_quirks of_r8a7795_compatible = {
> + .of_data = &of_data_rcar_gen3,
> + .quirks = &sdhi_quirks_bad_taps2367,
> +};
I'd suggest only a single space (and not a tabulator) before the "=".
Rest looks good so far!
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-30 4:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 10:20 [PATCH/RFC v2] mmc: host: renesas_sdhi: Refactor of_device_id.data Yoshihiro Shimoda
2021-06-30 4:41 ` Wolfram Sang [this message]
2021-06-30 7:10 ` Yoshihiro Shimoda
2021-06-30 7:34 ` Wolfram Sang
2021-06-30 7:43 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNv1/9WsdYu3ZwVv@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).