From: Wolfram Sang <wsa@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org, Pavel Machek <pavel@denx.de>
Subject: Re: [PATCH RESEND v2 3/3] i2c: rzv2m: Disable the operation of unit in case of error
Date: Mon, 5 Jun 2023 11:19:45 +0200 [thread overview]
Message-ID: <ZH2osTPbiv+sT+m5@shikoro> (raw)
In-Reply-To: <20230526135738.348294-4-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Fri, May 26, 2023 at 02:57:38PM +0100, Biju Das wrote:
> The remove and suspend callbacks disable the operation of the unit.
> Do the same in probe() in case of error.
>
> While at it, introduce a helper function rzv2m_i2c_disable() for
> disabling the operation of the unit and this function is shared
> between probe error path, remove and suspend callbacks.
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Applied to for-next, thanks!
Do you maybe want to add yourself as a MAINTAINER for this driver?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-05 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 13:57 [PATCH RESEND v2 0/3] RZ/V2M I2Cdriver clean ups Biju Das
2023-05-26 13:57 ` [PATCH RESEND v2 1/3] i2c: rzv2m: Drop extra space Biju Das
2023-06-05 9:17 ` Wolfram Sang
2023-05-26 13:57 ` [PATCH RESEND v2 2/3] i2c: rzv2m: Replace lowercase macros with static inline functions Biju Das
2023-06-05 9:19 ` Wolfram Sang
2023-05-26 13:57 ` [PATCH RESEND v2 3/3] i2c: rzv2m: Disable the operation of unit in case of error Biju Das
2023-06-05 9:19 ` Wolfram Sang [this message]
2023-06-05 9:32 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH2osTPbiv+sT+m5@shikoro \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pavel@denx.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).