From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] mmc: tmio_mmc_core: don't claim spurious interrupts
Date: Mon, 11 Feb 2019 19:37:53 +0300 [thread overview]
Message-ID: <eb1e55fd-6ed3-ec78-edf7-8311cbbf9a7b@cogentembedded.com> (raw)
In-Reply-To: <20190210174935.i7x4ysn64meuuli7@ninjato>
On 02/10/2019 08:49 PM, Wolfram Sang wrote:
>>>> + return ireg ? true : false;
>>>
>>> return ireg;
>>>
>>> ?
>>
>> How about !!ireg?
>
> Better. Still, I wonder how this cast is gonna be different from the
> cast being done because the return value is declared bool.
At least all the variants result in the same (quite bad) code with AArch64
and ARM gcc 4.8.5. Like this one:
mov w0, 1 // D.41524,
cbnz w23, .L353 // ireg,
.L297:
mov w0, 0 // D.41524,
b .L353 //
MBR, Sergei
prev parent reply other threads:[~2019-02-11 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 19:13 [PATCH v2] mmc: tmio_mmc_core: don't claim spurious interrupts Sergei Shtylyov
2019-02-09 21:40 ` Wolfram Sang
2019-02-10 17:35 ` Sergei Shtylyov
2019-02-10 17:49 ` Wolfram Sang
2019-02-11 16:37 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb1e55fd-6ed3-ec78-edf7-8311cbbf9a7b@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).