Re: [RFC PATCH v1 2/4] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329 SoCs GPADC

From: Rob Herring <robh@kernel.org>
To: Maxim Kiselev <bigunclemax@gmail.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	 Heiko Stuebner <heiko.stuebner@vrull.eu>,
	Mike Looijmans <mike.looijmans@topic.nl>,
	 Caleb Connolly <caleb.connolly@linaro.org>,
	devicetree@vger.kernel.org,
	 Ramona Bolboaca <ramona.bolboaca@analog.com>,
	ChiaEn Wu <chiaen_wu@richtek.com>,
	 linux-arm-kernel@lists.infradead.org,
	 Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	linux-iio@vger.kernel.org,
	 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Haibo Chen <haibo.chen@nxp.com>,  Chen-Yu Tsai <wens@csie.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	 Rob Herring <robh+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 Conor Dooley <conor@kernel.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	linux-sunxi@lists.linux.dev,  Palmer Dabbelt <palmer@dabbelt.com>,
	linux-kernel@vger.kernel.org,
	 Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
	linux-riscv@lists.infradead.org,
	 Jernej Skrabec <jernej.skrabec@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	ChiYuan Huang <cy_huang@richtek.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Samuel Holland <samuel@sholland.org>,
	 Cosmin Tanislav <demonsingur@gmail.com>,
	William Breathitt Gray <william.gray@linaro.org>
Subject: Re: [RFC PATCH v1 2/4] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329 SoCs GPADC
Date: Wed, 24 May 2023 04:21:00 -0500	[thread overview]
Message-ID: <168492006052.3187086.8767275310596142124.robh@kernel.org> (raw)
In-Reply-To: <20230524082744.3215427-3-bigunclemax@gmail.com>

On Wed, 24 May 2023 11:27:31 +0300, Maxim Kiselev wrote:
> Allwinner's D1, T113s and R329 SoCs have a new general purpose ADC.
> This ADC is the same for all of this SoCs. The only difference is
> the number of available channels.
> 
> Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>
> ---
>  .../iio/adc/allwinner,sun20i-d1-gpadc.yaml    | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml: 'maintainers' is a required property
	hint: Metaschema for devicetree binding documentation
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
Error: Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.example.dts:27.28-29 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1512: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230524082744.3215427-3-bigunclemax@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv