From: Andrew Lunn <andrew@lunn.ch>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
peter@korsgaard.com, palmer@sifive.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v1 v1 1/3] dt-bindings: i2c: add documentation for adding SiFive I2C driver
Date: Mon, 6 May 2019 15:19:19 +0200 [thread overview]
Message-ID: <20190506131919.GC15291@lunn.ch> (raw)
In-Reply-To: <1557147240-29551-2-git-send-email-sagar.kadam@sifive.com>
On Mon, May 06, 2019 at 06:23:58PM +0530, Sagar Shrikant Kadam wrote:
> Add DT binding for OpenCore's based i2c device as found in
> FU540 Chipset on HiFive Unleashed Platform (Rev A00).
>
> The doc explains, how to add DT support for I2C devices.
>
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
> .../devicetree/bindings/i2c/i2c-sifive.txt | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-sifive.txt
Hi Sagar
Please extend the existing i2c-ocores.txt file, not add a new file.
Andrew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-06 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 12:53 [PATCH v1 v1 0/3] Add dt bindings to support I2C on sifive devices and a fix for polling mode i2c transfers Sagar Shrikant Kadam
2019-05-06 12:53 ` [PATCH v1 v1 1/3] dt-bindings: i2c: add documentation for adding SiFive I2C driver Sagar Shrikant Kadam
2019-05-06 13:19 ` Andrew Lunn [this message]
2019-05-06 17:41 ` Sagar Kadam
2019-05-06 12:53 ` [PATCH v1 v1 2/3] i2c-ocore: sifive: add support for i2c device on FU540-c000 SoC Sagar Shrikant Kadam
2019-05-06 12:54 ` [PATCH v1 v1 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2019-05-06 13:29 ` Andrew Lunn
2019-05-06 17:54 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506131919.GC15291@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).