From: Rob Herring <robh@kernel.org>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: mark.rutland@arm.com, andrew@lunn.ch, peter@korsgaard.com,
devicetree@vger.kernel.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
paul.walmsley@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v7 1/3] dt-bindings: i2c: extend existing opencore bindings.
Date: Fri, 24 May 2019 15:40:12 -0500 [thread overview]
Message-ID: <20190524204012.GA2580@bogus> (raw)
In-Reply-To: <1558515574-11155-2-git-send-email-sagar.kadam@sifive.com>
On Wed, May 22, 2019 at 02:29:32PM +0530, Sagar Shrikant Kadam wrote:
> Reformatted compatibility strings to one valid combination on
> each line.
> Add FU540-C000 specific device tree bindings to already available
> i2-ocores file. This device is available on
> HiFive Unleashed Rev A00 board. Move interrupt under optional
> property list as this can be optional.
>
> The FU540-C000 SoC from sifive, has an Opencore's I2C block
> reimplementation.
>
> The DT compatibility string for this IP is present in HDL and available at.
> https://github.com/sifive/sifive-blocks/blob/master/src/main/scala/devices/i2c/I2C.scala#L73
>
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-ocores.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> index 17bef9a..db96951 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> @@ -1,9 +1,13 @@
> Device tree configuration for i2c-ocores
>
> Required properties:
> -- compatible : "opencores,i2c-ocores" or "aeroflexgaisler,i2cmst"
> +- compatible : "opencores,i2c-ocores",
> + "aeroflexgaisler,i2cmst",
> + "sifive,fu540-c000-i2c","sifive,i2c0".
space needed ^
And drop the end of line commas and period.
> + For Opencore based I2C IP block reimplemented in
> + FU540-C000 SoC.Please refer sifive-blocks-ip-versioning.txt
And here too.
And 'refer to'
> + for additional details.
> - reg : bus address start and address range size of device
> -- interrupts : interrupt number
> - clocks : handle to the controller clock; see the note below.
> Mutually exclusive with opencores,ip-clock-frequency
> - opencores,ip-clock-frequency: frequency of the controller clock in Hz;
> @@ -12,6 +16,7 @@ Required properties:
> - #size-cells : should be <0>
>
> Optional properties:
> +- interrupts : interrupt number.
> - clock-frequency : frequency of bus clock in Hz; see the note below.
> Defaults to 100 KHz when the property is not specified
> - reg-shift : device register offsets are shifted by this value
> --
> 1.9.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-24 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:59 [PATCH v7 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Sagar Shrikant Kadam
2019-05-22 8:59 ` [PATCH v7 1/3] dt-bindings: i2c: extend existing opencore bindings Sagar Shrikant Kadam
2019-05-24 20:40 ` Rob Herring [this message]
2019-05-27 13:25 ` Sagar Kadam
2019-05-22 8:59 ` [PATCH v7 2/3] i2c-ocores: sifive: add support for i2c device on FU540-c000 SoC Sagar Shrikant Kadam
2019-05-22 8:59 ` [PATCH v7 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2019-05-22 19:45 ` Andrew Lunn
[not found] ` <CAARK3HmMVibudG2CFLBoMSAqnraXyirTL6CXYo1T_XJEuGJy7Q@mail.gmail.com>
2019-05-23 12:34 ` Andrew Lunn
2019-05-23 13:43 ` Sagar Kadam
2019-05-23 13:53 ` Wolfram Sang
2019-05-24 5:05 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524204012.GA2580@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).