From: Christoph Hellwig <hch@lst.de>
To: Palmer Dabbelt <palmer@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org
Subject: [PATCH 6/8] riscv: use get_cpu and put_cpu in sys_riscv_flush_icache
Date: Thu, 22 Aug 2019 15:56:10 +0900 [thread overview]
Message-ID: <20190822065612.28634-7-hch@lst.de> (raw)
In-Reply-To: <20190822065612.28634-1-hch@lst.de>
Use get_cpu/put_cpu instead of opencoding them.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/riscv/mm/cacheflush.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/riscv/mm/cacheflush.c b/arch/riscv/mm/cacheflush.c
index dacf72f94d12..9180b2e93058 100644
--- a/arch/riscv/mm/cacheflush.c
+++ b/arch/riscv/mm/cacheflush.c
@@ -19,11 +19,9 @@ void flush_icache_all(void)
static void flush_icache_mm(bool local)
{
- unsigned int cpu;
+ unsigned int cpu = get_cpu();
cpumask_t others, hmask;
- preempt_disable();
-
/*
* Mark the I$ for all harts not concurrently executing as needing a
* flush for this MM.
@@ -32,7 +30,6 @@ static void flush_icache_mm(bool local)
cpu_possible_mask, mm_cpumask(current->mm));
/* Flush this hart's I$ now, and mark it as flushed. */
- cpu = smp_processor_id();
local_flush_icache_all();
/*
@@ -55,7 +52,7 @@ static void flush_icache_mm(bool local)
smp_mb();
}
- preempt_enable();
+ put_cpu();
}
#else
#define flush_icache_mm(local) flush_icache_all()
--
2.20.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-22 6:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 6:56 sys_riscv_flush_icache Christoph Hellwig
2019-08-22 6:56 ` [PATCH 1/8] riscv: fix the flags argument type for riscv_riscv_flush_icache Christoph Hellwig
2019-08-22 6:56 ` [PATCH 2/8] riscv: remove SYS_RISCV_FLUSH_ICACHE_LOCAL #define Christoph Hellwig
2019-08-22 6:56 ` [PATCH 3/8] riscv: move sys_riscv_flush_icache to cacheflush.c Christoph Hellwig
2019-08-22 6:56 ` [PATCH 4/8] riscv: remove the active_mm check in sys_riscv_flush_icache Christoph Hellwig
2019-08-22 6:56 ` [PATCH 5/8] riscv: actually clear icache_stale_mask for all harts in mm_cpumask Christoph Hellwig
2019-08-22 18:29 ` Atish Patra
2019-08-26 11:41 ` hch
2019-08-22 6:56 ` Christoph Hellwig [this message]
2019-08-22 17:49 ` [PATCH 6/8] riscv: use get_cpu and put_cpu in sys_riscv_flush_icache Atish Patra
2019-08-26 11:38 ` hch
2019-08-27 18:42 ` Atish Patra
2019-08-22 6:56 ` [PATCH 7/8] riscv: improve the local flushing logic " Christoph Hellwig
2019-08-22 17:34 ` Atish Patra
2019-08-26 11:36 ` hch
2019-08-22 6:56 ` [PATCH 8/8] riscv: ignore the SYS_RISCV_FLUSH_ICACHE_LOCAL flag Christoph Hellwig
2019-08-28 1:10 ` Palmer Dabbelt
2019-08-28 6:09 ` Christoph Hellwig
2019-09-03 18:46 ` Palmer Dabbelt
2019-09-06 17:07 ` Christoph Hellwig
2019-09-13 19:44 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822065612.28634-7-hch@lst.de \
--to=hch@lst.de \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).