From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84E5C3A59F for ; Mon, 26 Aug 2019 11:38:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C18720874 for ; Mon, 26 Aug 2019 11:38:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iKjm9bRZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C18720874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BOag1hBBY11PeUZioBl/r8/2H9QBm9qhRT+Taf8G4a0=; b=iKjm9bRZRN7cpE ofxhdyc3SwJObE9i909CREWGhVif1+1/vZJvtUA8g0aWmlfwrZ5Aco/pRaCjuss1YJfOp9CHYcQYa S5TSTaZU7hKTunsGH0gB1JZ3TjJt6bpQd0KxpFPf+uA4iBSThKr/A7iVSFfmg5TEGupBJRG3iZAyt DxdcdpOJPsVIX1VAetP15/CXT4Q0yTxh1u89yd8QRsGr/C1nN9EBgrVL3uBvqm31rjiE6m1ukz61Q W8nof7y8igNWWDsux0Y8TLfry80tzFyqPHqbrV4Q+02I3g9Z6IPpObGYrHf3dll6+T7IDwOlJpdXc U34fziEKFBuCRT1MBfow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2DKa-0002a8-IU; Mon, 26 Aug 2019 11:38:40 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2DKY-0002Zb-4v for linux-riscv@lists.infradead.org; Mon, 26 Aug 2019 11:38:39 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0958568AFE; Mon, 26 Aug 2019 13:38:35 +0200 (CEST) Date: Mon, 26 Aug 2019 13:38:34 +0200 From: "hch@lst.de" To: Atish Patra Subject: Re: [PATCH 6/8] riscv: use get_cpu and put_cpu in sys_riscv_flush_icache Message-ID: <20190826113834.GE15002@lst.de> References: <20190822065612.28634-1-hch@lst.de> <20190822065612.28634-7-hch@lst.de> <157504fc8f48057a8198e39262a786f901e67cd2.camel@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <157504fc8f48057a8198e39262a786f901e67cd2.camel@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_043838_338679_F9189B83 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-riscv@lists.infradead.org" , "palmer@sifive.com" , "hch@lst.de" , "paul.walmsley@sifive.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2019 at 05:49:20PM +0000, Atish Patra wrote: > On Thu, 2019-08-22 at 15:56 +0900, Christoph Hellwig wrote: > > Use get_cpu/put_cpu instead of opencoding them. > > > > Signed-off-by: Christoph Hellwig > > --- > > arch/riscv/mm/cacheflush.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/arch/riscv/mm/cacheflush.c b/arch/riscv/mm/cacheflush.c > > index dacf72f94d12..9180b2e93058 100644 > > --- a/arch/riscv/mm/cacheflush.c > > +++ b/arch/riscv/mm/cacheflush.c > > @@ -19,11 +19,9 @@ void flush_icache_all(void) > > > > static void flush_icache_mm(bool local) > > { > > - unsigned int cpu; > > + unsigned int cpu = get_cpu(); > > I thought it is recommended to put variables with assignment at the > end. But I can't find anything about it in coding guidelines. So it > might be all in my head ;-) I've never heard of that before. In fact I usually keep them at the beginning. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv