From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH] riscv: resolve most warnings from sparse
Date: Thu, 26 Sep 2019 23:29:18 +0200 [thread overview]
Message-ID: <20190926212918.w2i6wigveopngtnm@desk.local> (raw)
In-Reply-To: <20190919173142.GA26224@infradead.org>
On Thu, Sep 19, 2019 at 10:31:42AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 19, 2019 at 01:26:38AM -0700, Paul Walmsley wrote:
> >
> > Resolve most of the warnings emitted by sparse. The objective here is
> > to keep arch/riscv as clean as possible with regards to sparse warnings,
> > and to maintain this bar for subsequent patches.
>
> I think this patch does just way to many different things and needs
> to be split up into one patch per issue / code module.
>
> > --- /dev/null
> > +++ b/arch/riscv/include/asm/entry.h
>
> For example adding this file should be a patch on its own. It can
> also move to arch/riscv/kernel/ instead of polluting the <asm/*.h>
> namespace. That being said I'm not sure I like this and the
> head.h patches. Just adding a header for entry points used from
> aseembly only seems rather pointless, I wonder if there is a way
> to just shut up sparse on them. Same for most of head.h.
The pseudo-specifier '__visible' (for __attribute__((__externally_visible__)))
is defined for this.
Best regards,
-- Luc Van Oostenryck
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-09-26 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 8:26 [PATCH] riscv: resolve most warnings from sparse Paul Walmsley
2019-09-19 17:31 ` Christoph Hellwig
2019-09-21 10:07 ` Paul Walmsley
2019-09-26 21:29 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926212918.w2i6wigveopngtnm@desk.local \
--to=luc.vanoostenryck@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).