From: Christoph Hellwig <hch@infradead.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
monstr@monstr.eu, Albert Ou <aou@eecs.berkeley.edu>,
linux-kbuild@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Palmer Dabbelt <palmer@sifive.com>,
Kuldeep Dave <kuldeep.dave@xilinx.com>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Firoz Khan <firoz.khan@linaro.org>,
git@xilinx.com, Paul Walmsley <paul.walmsley@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] microblaze: Include generic support for MSI irqdomains
Date: Tue, 15 Oct 2019 00:47:17 -0700 [thread overview]
Message-ID: <20191015074717.GB8715@infradead.org> (raw)
In-Reply-To: <c558db03-1199-275d-3e42-612c71cbf736@xilinx.com>
On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote:
> On 08. 10. 19 17:46, Christoph Hellwig wrote:
> > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote:
> >> index e5c9170a07fc..83417105c00a 100644
> >> --- a/arch/microblaze/include/asm/Kbuild
> >> +++ b/arch/microblaze/include/asm/Kbuild
> >> @@ -25,6 +25,7 @@ generic-y += local64.h
> >> generic-y += mcs_spinlock.h
> >> generic-y += mm-arch-hooks.h
> >> generic-y += mmiowb.h
> >> +generic-y += msi.h
> >
> > Please just mark it as mandatory-y in the asm-generic makefile
> > instead of requiring a sniplet for every architecture.
> >
>
> But is it really mandatory for all architectures?
What the mandatory-y keyword means is that every architecture that
doesn't provide its own header gets the default one, which seems
applicable here. Maybe the keyword is a bit misnamed and should be
default-y or something like that..
But in this case I think we have a clear case of x86 vs the rest, which
is unlikely to change in a major way.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-15 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 10:34 [PATCH] microblaze: Include generic support for MSI irqdomains Michal Simek
2019-10-08 15:46 ` Christoph Hellwig
2019-10-10 10:47 ` Michal Simek
2019-10-15 7:47 ` Christoph Hellwig [this message]
2019-10-15 8:46 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015074717.GB8715@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=firoz.khan@linaro.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=kuldeep.dave@xilinx.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=will@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).