From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Maksim Kiselev" <bigunclemax@gmail.com>,
linux-iio@vger.kernel.org, "Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Cosmin Tanislav" <demonsingur@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ramona Bolboaca" <ramona.bolboaca@analog.com>,
"Caleb Connolly" <caleb.connolly@linaro.org>,
"ChiYuan Huang" <cy_huang@richtek.com>,
"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
"William Breathitt Gray" <william.gray@linaro.org>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC
Date: Sun, 4 Jun 2023 11:42:06 +0100 [thread overview]
Message-ID: <20230604114206.789708a2@jic23-huawei> (raw)
In-Reply-To: <ZHoBXxM80aqvLZNt@smile.fi.intel.com>
> > + if (!wait_for_completion_timeout(&info->completion,
> > + msecs_to_jiffies(100))) {
>
> Dunno if it's better to have this parameter to be defined with self-explanatory
> name.
Probably a response to my earlier comment. I'd agree with a good name
but GPADC_TIMEOUT which was the earlier naming is less use than a value
and it's not obvious what that name should be.
A nice datasheet reference would be good to have though.
>
> > + ret = -ETIMEDOUT;
> > + goto err;
> > + }
>
>
> > + if (num_channels > SUN20I_GPADC_MAX_CHANNELS) {
> > + dev_err(dev, "num of channel children out of range");
> > + return -EINVAL;
> > + }
>
> Is it really critical error?
Overflow of registers - so yes. I wondered this on v1 and went digging :)
Now, there are no such devices known, so meh on whether check is useful.
>
> ...
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-06-04 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 22:30 [PATCH v2 0/3] Add support for Allwinner GPADC on D1/T113s/R329/T507 SoCs Maksim Kiselev
2023-06-01 22:30 ` [PATCH v2 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC Maksim Kiselev
2023-06-02 14:49 ` Andy Shevchenko
2023-06-04 10:42 ` Jonathan Cameron [this message]
2023-06-04 20:53 ` Maxim Kiselev
2023-06-04 10:46 ` Jonathan Cameron
2023-06-01 22:30 ` [PATCH v2 2/3] dt-bindings: " Maksim Kiselev
2023-06-01 23:31 ` Rob Herring
2023-06-02 8:38 ` Krzysztof Kozlowski
2023-06-04 20:20 ` Maxim Kiselev
2023-06-04 21:00 ` Conor Dooley
2023-06-05 6:24 ` Krzysztof Kozlowski
2023-06-01 22:30 ` [PATCH v2 3/3] riscv: dts: allwinner: d1: Add GPADC node Maksim Kiselev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230604114206.789708a2@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bigunclemax@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mike.looijmans@topic.nl \
--cc=miquel.raynal@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).