From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
To: andy.shevchenko@gmail.com
Cc: oe-kbuild-all@lists.linux.dev, linus.walleij@linaro.org,
brgl@bgdev.pl, palmer@dabbelt.com, paul.walmsley@sifive.com,
linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: [PATCH v2] gpio: sifive: Add missing check for platform_get_irq
Date: Mon, 5 Jun 2023 09:17:10 +0800 [thread overview]
Message-ID: <20230605011710.52-1-jiasheng@iscas.ac.cn> (raw)
On Sun, 4 Jun 2023 04:59:46 +0800 Andy Shevchenko wrote:
>> 224 for (i = 0; i < ngpio; i++) {
>> 225 chip->irq_number[i] = platform_get_irq(pdev, i);
>> > 226 if (chip->irq_number[i] < 0)
>> 227 return chip->irq_number[i];
>
> So, this should be
>
> ret = ...
> if (ret < 0)
> return ret;
> irq_number = ret;
>
>> 228 }
I will submit a v3 to fix it.
Also, the same goes for the other patch
"gpio: ath79: Add missing check for platform_get_irq".
Thanks,
Jiasheng
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2023-06-06 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 1:17 Jiasheng Jiang [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-02 7:27 [PATCH v2] gpio: sifive: Add missing check for platform_get_irq Jiasheng Jiang
2023-06-02 13:03 ` Andy Shevchenko
2023-06-03 17:47 ` kernel test robot
2023-06-03 20:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605011710.52-1-jiasheng@iscas.ac.cn \
--to=jiasheng@iscas.ac.cn \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).