From: Greg KH <gregkh@linuxfoundation.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
sashal@kernel.org, palmer@dabbelt.com, conor@kernel.org,
paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
ndesaulniers@google.com, trix@redhat.com, stable@vger.kernel.org,
linux-riscv@lists.infradead.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH 6.3] riscv: vmlinux.lds.S: Explicitly handle '.got' section
Date: Wed, 7 Jun 2023 20:32:58 +0200 [thread overview]
Message-ID: <2023060752-chaffing-unable-8b26@gregkh> (raw)
In-Reply-To: <20230606-exploit-refill-b9311f2378f3@wendy>
On Tue, Jun 06, 2023 at 11:40:35AM +0100, Conor Dooley wrote:
> On Mon, Jun 05, 2023 at 02:15:08PM -0700, Nathan Chancellor wrote:
> > This patch is for linux-6.3.y only, it has no direct mainline
> > equivalent.
> >
> > LLVM 17 will now use the GOT for extern weak symbols when using the
> > medany model, which causes a linker orphan section warning on
> > linux-6.3.y:
> >
> > ld.lld: warning: <internal>:(.got) is being placed in '.got'
> >
> > This is not an issue in mainline because handling of the .got section
> > was added by commit 39b33072941f ("riscv: Introduce CONFIG_RELOCATABLE")
> > and further extended by commit 26e7aacb83df ("riscv: Allow to downgrade
> > paging mode from the command line") in 6.4-rc1. Neither of these changes
> > are suitable for stable, so add explicit handling of the .got section in
> > a standalone change to align 6.3 and mainline, which addresses the
> > warning.
> >
> > This is only an issue for 6.3 because commit f4b71bff8d85 ("riscv:
> > select ARCH_WANT_LD_ORPHAN_WARN for !XIP_KERNEL") landed in 6.3-rc1, so
> > earlier releases will not see this warning because it will not be
> > enabled.
> >
> > Closes: https://github.com/ClangBuiltLinux/linux/issues/1865
> > Link: https://github.com/llvm/llvm-project/commit/a178ba9fbd0a27057dc2fa4cb53c76caa013caac
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Seems reasonable to me chief.
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Now queued up,t hanks.
greg k-h
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-06-07 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 21:15 [PATCH 6.3] riscv: vmlinux.lds.S: Explicitly handle '.got' section Nathan Chancellor
2023-06-06 10:40 ` Conor Dooley
2023-06-07 18:32 ` Greg KH [this message]
2023-06-07 18:41 ` Patch "riscv: vmlinux.lds.S: Explicitly handle '.got' section" has been added to the 6.3-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023060752-chaffing-unable-8b26@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=palmer@dabbelt.com \
--cc=patches@lists.linux.dev \
--cc=paul.walmsley@sifive.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).