linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: Conor Dooley <conor@kernel.org>
Cc: Palmer Dabbelt <palmer@rivosinc.com>, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: Provide a more helpful error message on invalid ISA strings
Date: Fri, 30 Jun 2023 10:06:21 +0200	[thread overview]
Message-ID: <20230630-23916a0715029ac07d5de6fc@orel> (raw)
In-Reply-To: <20230630-valiant-chimp-ba079aedffe8@spud>

On Fri, Jun 30, 2023 at 12:17:27AM +0100, Conor Dooley wrote:
...
>  old_interface:
> -	if (!IS_ENABLED(CONFIG_RISCV_ISA_FALLBACK) && !riscv_isa_fallback_cmdline)
> +	if (!IS_ENABLED(CONFIG_RISCV_ISA_FALLBACK) && !riscv_isa_fallback_cmdline) {
> +		pr_warn("CPU with hartid=%lu is invalid, this kernel does not parse riscv,isa",

\"riscv,isa\" to match the way it's done below.

> +			*hart);
>  		return -ENODEV;
> +	}
>  
>  	if (of_property_read_string(node, "riscv,isa", &isa)) {
>  		pr_warn("CPU with hartid=%lu has no \"riscv,isa-base\" or \"riscv,isa\" property\n",
> 


Thanks,
drew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-06-30  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 22:35 [PATCH] RISC-V: Provide a more helpful error message on invalid ISA strings Palmer Dabbelt
2023-06-29 23:17 ` Conor Dooley
2023-06-30  8:06   ` Andrew Jones [this message]
2023-07-06 17:28   ` Palmer Dabbelt
2023-07-06 17:46     ` Conor Dooley
2023-07-06 17:54       ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230630-23916a0715029ac07d5de6fc@orel \
    --to=ajones@ventanamicro.com \
    --cc=conor@kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).