From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Add T-HEAD PWM controller
Date: Wed, 4 Oct 2023 16:02:51 +0200 [thread overview]
Message-ID: <20231004140251.smwazlizo5nmpz2a@pengutronix.de> (raw)
In-Reply-To: <20231004092731.1362-2-jszhang@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 316 bytes --]
Hello,
On Wed, Oct 04, 2023 at 05:27:30PM +0800, Jisheng Zhang wrote:
> + "#pwm-cells":
> + const: 2
Please make this a 3.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-10-04 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 9:27 [PATCH v2 0/2] pwm: add driver for T-THEAD TH1520 SoC Jisheng Zhang
2023-10-04 9:27 ` [PATCH v2 1/2] dt-bindings: pwm: Add T-HEAD PWM controller Jisheng Zhang
2023-10-04 14:02 ` Uwe Kleine-König [this message]
2023-10-04 15:07 ` Rob Herring
2023-10-04 9:27 ` [PATCH v2 2/2] pwm: add T-HEAD PWM driver Jisheng Zhang
2023-10-04 14:01 ` Uwe Kleine-König
2023-10-05 14:06 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004140251.smwazlizo5nmpz2a@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).