linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor.dooley@microchip.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Jia Jie Ho <jiajie.ho@starfivetech.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE
Date: Mon, 11 Dec 2023 13:50:12 +0000	[thread overview]
Message-ID: <20231211-grumble-haphazard-e95ab97e0e57@wendy> (raw)
In-Reply-To: <20231211143611.5d0248bf@namcao>


[-- Attachment #1.1: Type: text/plain, Size: 1974 bytes --]

On Mon, Dec 11, 2023 at 02:36:11PM +0100, Nam Cao wrote:
> On Tue, 28 Nov 2023 10:59:44 +0000 Conor Dooley <conor.dooley@microchip.com> wrote:
> > On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote:
> > > On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote:  
> > > > Selects ARM_AMBA platform support for StarFive SoCs required by spi and
> > > > crypto dma engine.
> > > > 
> > > > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > > > ---
> > > >  arch/riscv/Kconfig.socs | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> > > > index 1cf69f958f10..381cd46e6373 100644
> > > > --- a/arch/riscv/Kconfig.socs
> > > > +++ b/arch/riscv/Kconfig.socs
> > > > @@ -29,6 +29,7 @@ config SOC_STARFIVE
> > > >  	bool "StarFive SoCs"
> > > >  	select PINCTRL
> > > >  	select RESET_CONTROLLER
> > > > +	select ARM_AMBA
> > > >  	help
> > > >  	  This enables support for StarFive SoC platform hardware.  
> > > 
> > > I'm considering sending this to stable trees. Without this, it is not
> > > possible to configure the kernel with SPI driver for the starfive board.
> > > 
> > > I just want to check with you first, in case I miss something obvious.
> > > Any objection to backporting this patch?  
> > 
> > Personally I would be okay with that, otherwise the driver is dead code
> > in those stable versions. Just be sure that the rename of some pl011
> > variables (I think that's what it was) that was a pre-req for this being
> > merged is in said versions of stable. An allmodconfig should flag
> > whether that has happened pretty quickly.
> 
> Thanks for the info. I think I found what you are talking about:
> a1a5f2c88725 ("dmaengine: pl330: rename _start to prevent build error")
> 
> It's been a while and no one else said anything, so I am going forward with
> this.

Yeah, that's the one. Sorry that I did not recall correctly.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2023-12-11 13:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  6:18 [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE Jia Jie Ho
2023-05-25  6:23 ` Conor Dooley
2023-06-20 15:11   ` Palmer Dabbelt
2023-07-09 22:10 ` Conor Dooley
2023-10-16 13:26   ` Nam Cao
2023-10-16 13:30     ` Conor Dooley
2023-11-28 10:27 ` Nam Cao
2023-11-28 10:59   ` Conor Dooley
2023-12-11 13:36     ` Nam Cao
2023-12-11 13:50       ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211-grumble-haphazard-e95ab97e0e57@wendy \
    --to=conor.dooley@microchip.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=jiajie.ho@starfivetech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=namcao@linutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).