From: Samuel Holland <samuel.holland@sifive.com>
To: Conor Dooley <conor@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH] serial: sifive: Remove 0 from fu540-c000-uart0 binding.
Date: Thu, 7 Mar 2024 11:43:53 -0600 [thread overview]
Message-ID: <4d85215e-64ca-491c-8f69-f2c83c7e72d7@sifive.com> (raw)
In-Reply-To: <20240307-sacrifice-dares-09c91fc8fefe@spud>
Hi Conor, Sebastian,
On 2024-03-07 11:39 AM, Conor Dooley wrote:
> On Thu, Mar 07, 2024 at 10:09:50AM +0100, Sebastian Andrzej Siewior wrote:
>> The driver is using "sifive,fu540-c000-uart0" as a binding. The device
>> tree and documentation states "sifive,fu540-c000-uart" instead. This
>> means the binding is not matched and not used.
>>
>> This did not cause any problems because the alternative binding, used in
>> the device tree, "sifive,uart0" is not handling the hardware any
>> different.
>>
>> Align the binding in the driver with the documentation.
>>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>> ---
>> On 2024-03-06 18:48:13 [-0800], Paul Walmsley wrote:
>>> On Mon, 4 Mar 2024, Conor Dooley wrote:
>>>> I suspect that the driver is what's incorrect, given there's little
>>>> value in putting the IP version in the SoC-specific compatible as it's
>>>> a fixed implementation. I'd change the driver to match the bindings.
>>>
>>> Agreed
>>
>
>> I didn't add any stable/ fixes tags as I guess there is no point in
>> backporting this.
>
> Every documented device falls back to "sifive,uart0", as you mention
> above, so I think that's reasonable.
Right. In fact this means the sifive,fu540-c000-uart compatible can be removed
from the driver entirely, since the driver would match sifive,uart0 anyway.
Regards,
Samuel
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks,
> Conor.
>
>>
>>> - Paul
>>
>> drivers/tty/serial/sifive.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c
>> index 0670fd9f84967..cbfce65c9d221 100644
>> --- a/drivers/tty/serial/sifive.c
>> +++ b/drivers/tty/serial/sifive.c
>> @@ -761,7 +761,7 @@ static int __init early_sifive_serial_setup(struct earlycon_device *dev,
>> }
>>
>> OF_EARLYCON_DECLARE(sifive, "sifive,uart0", early_sifive_serial_setup);
>> -OF_EARLYCON_DECLARE(sifive, "sifive,fu540-c000-uart0",
>> +OF_EARLYCON_DECLARE(sifive, "sifive,fu540-c000-uart",
>> early_sifive_serial_setup);
>> #endif /* CONFIG_SERIAL_EARLYCON */
>>
>> @@ -1032,7 +1032,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(sifive_uart_pm_ops, sifive_serial_suspend,
>> sifive_serial_resume);
>>
>> static const struct of_device_id sifive_serial_of_match[] = {
>> - { .compatible = "sifive,fu540-c000-uart0" },
>> + { .compatible = "sifive,fu540-c000-uart" },
>> { .compatible = "sifive,uart0" },
>> {},
>> };
>> --
>> 2.43.0
>>
>> Sebastian
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-07 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 10:59 [RFC] Inconsistent sifive,fu540-c000-uart binding Sebastian Andrzej Siewior
2024-03-04 18:53 ` Conor Dooley
2024-03-07 2:48 ` Paul Walmsley
2024-03-07 9:09 ` [PATCH] serial: sifive: Remove 0 from fu540-c000-uart0 binding Sebastian Andrzej Siewior
2024-03-07 17:39 ` Conor Dooley
2024-03-07 17:43 ` Samuel Holland [this message]
2024-03-07 17:56 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d85215e-64ca-491c-8f69-f2c83c7e72d7@sifive.com \
--to=samuel.holland@sifive.com \
--cc=bigeasy@linutronix.de \
--cc=conor@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).