From: Greentime Hu <greentime.hu@sifive.com>
To: greentime.hu@sifive.com, greentime@kernel.org,
anup@brainfault.org, palmer@dabbelt.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
rppt@linux.ibm.com, gkulkarni@marvell.com, will@kernel.org,
catalin.marinas@arm.com, mark.rutland@arm.com,
paul.walmsley@sifive.com, hch@lst.de
Subject: [RFC PATCH v2 3/4] riscv: Use variable this_cpu instead of smp_processor_id()
Date: Fri, 10 Jan 2020 18:46:26 +0800 [thread overview]
Message-ID: <5a30a3a637af05041780214287f46ea576818c99.1577694824.git.greentime.hu@sifive.com> (raw)
In-Reply-To: <cover.1577694824.git.greentime.hu@sifive.com>
In-Reply-To: <cover.1577694824.git.greentime.hu@sifive.com>
To clean up codes in smpboot.c by using a variable this_cpu to prevent too
many calls for smp_processor_id()
Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
---
arch/riscv/kernel/smpboot.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
index 8bc01f0ca73b..ceef7c579aeb 100644
--- a/arch/riscv/kernel/smpboot.c
+++ b/arch/riscv/kernel/smpboot.c
@@ -46,6 +46,9 @@ void __init smp_prepare_boot_cpu(void)
void __init smp_prepare_cpus(unsigned int max_cpus)
{
int cpuid;
+ unsigned int this_cpu;
+
+ this_cpu = smp_processor_id();
/* This covers non-smp usecase mandated by "nosmp" option */
if (max_cpus == 0)
@@ -137,6 +140,9 @@ void __init smp_cpus_done(unsigned int max_cpus)
asmlinkage __visible void __init smp_callin(void)
{
struct mm_struct *mm = &init_mm;
+ unsigned int this_cpu;
+
+ this_cpu = smp_processor_id();
if (!IS_ENABLED(CONFIG_RISCV_SBI))
clint_clear_ipi(cpuid_to_hartid_map(smp_processor_id()));
@@ -146,9 +152,9 @@ asmlinkage __visible void __init smp_callin(void)
current->active_mm = mm;
trap_init();
- notify_cpu_starting(smp_processor_id());
- update_siblings_masks(smp_processor_id());
- set_cpu_online(smp_processor_id(), 1);
+ notify_cpu_starting(this_cpu);
+ update_siblings_masks(this_cpu);
+ set_cpu_online(this_cpu, true);
/*
* Remote TLB flushes are ignored while the CPU is offline, so emit
* a local TLB flush right now just in case.
--
2.17.1
next prev parent reply other threads:[~2020-01-10 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 10:46 [RFC PATCH v2 0/4] riscv: Add numa support for riscv64 platform Greentime Hu
2020-01-10 10:46 ` [RFC PATCH v2 1/4] riscv: Add support pte_protnone and pmd_protnone if CONFIG_NUMA_BALANCING Greentime Hu
2020-01-10 10:46 ` [RFC PATCH v2 2/4] riscv: Move unflatten_device_tree() to paging_init() because riscv_numa_init() needs the dt information Greentime Hu
2020-01-10 10:46 ` Greentime Hu [this message]
2020-01-10 10:46 ` [RFC PATCH v2 4/4] riscv: Add numa support for riscv64 platform Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a30a3a637af05041780214287f46ea576818c99.1577694824.git.greentime.hu@sifive.com \
--to=greentime.hu@sifive.com \
--cc=anup@brainfault.org \
--cc=catalin.marinas@arm.com \
--cc=gkulkarni@marvell.com \
--cc=greentime@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).