From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: Conor.Dooley@microchip.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, anup@brainfault.org,
heiko@sntech.de, guoren@kernel.org, mick@ics.forth.gr,
alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com,
dyoung@redhat.com, corbet@lwn.net
Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
crash-utility@redhat.com, huanyi.xj@alibaba-inc.com,
heinrich.schuchardt@canonical.com, k-hagio-ab@nec.com,
hschauhan@nulltrace.org, yixun.lan@gmail.com
Subject: Re: [PATCH V5 0/6] RISC-V fixups to work with crash tool
Date: Thu, 11 Aug 2022 10:54:22 +0800 [thread overview]
Message-ID: <5afbd9b6-37c5-8a8d-6fdf-bca721ebd25e@linux.alibaba.com> (raw)
In-Reply-To: <b3184653-7ef4-eec3-9ef6-a8449fe24323@microchip.com>
在 2022/8/10 上午5:24, Conor.Dooley@microchip.com 写道:
> On 09/08/2022 07:58, Xianting Tian wrote:
>> Hi Palmer
>>
>> Could you please help review this patch set? thanks.
> Hey Xianting,
>
> Obviously I am not Palmer, but I left some comments on the
> patchset. Sorry for the delay in getting back onto you on your
> latest version, I got confused as to which versions I had reviewed.
You ever reviewed this version patch set,
https://lore.kernel.org/lkml/20220725014539.1037627-1-xianting.tian@linux.alibaba.com/
<https://lore.kernel.org/lkml/20220725014539.1037627-1-xianting.tian@linux.alibaba.com/>
>
> Conor.
>
>>
>> Crash-utility patch set is ready(acked by HAGIO KAZUHITO), now waiting the kernel patch set merged firstly.
>>
>> 在 2022/8/2 下午8:18, Xianting Tian 写道:
>>> I ever sent the patch 1 in the link:
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-3-xianting.tian@linux.alibaba.com/
>>> And patch 2,3 in the link:
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-2-xianting.tian@linux.alibaba.com/
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-3-xianting.tian@linux.alibaba.com/
>>>
>>> This patch set just put these patches together, and with three new patch 4, 5, 6.
>>> these six patches are the fixups for machine_kexec, kernel mode PC for vmcore
>>> and improvements for vmcoreinfo, memory layout dump and fixup chedule out issue
>>> in machine_crash_shutdown().
>>>
>>> The main changes in the six patchs as below,
>>> Patch 1: use __smp_processor_id() instead of smp_processor_id() to cleanup
>>> the console prints.
>>> Patch 2: Add VM layout, va bits, ram base to vmcoreinfo, which can simplify
>>> the development of crash tool as ARM64 already did
>>> (arch/arm64/kernel/crash_core.c).
>>> Patch 3: Add modules to virtual kernel memory layout dump.
>>> Patch 4: Fixup to get correct kernel mode PC for vmcore.
>>> Patch 5: Updates vmcoreinfo.rst.
>>> Patch 6: Fixup schedule out issue in machine_crash_shutdown()
>>>
>>> With these six patches(patch 2 is must), crash tool can work well to analyze
>>> a vmcore. The patches for crash tool for RISCV64 is in the link:
>>> https://lore.kernel.org/linux-riscv/20220801043040.2003264-1-xianting.tian@linux.alibaba.com/
>>>
>>> ------
>>> Changes v1 -> v2:
>>> 1, remove the patch "Add a fast call path of crash_kexec()" from this series
>>> of patches, as it already applied to riscv git.
>>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>>> 2, add 'Reviewed-by' based on the comments of v1.
>>> Changes v2 -> v3:
>>> use "riscv" instead of "riscv64" in patch 5 subject line.
>>> Changes v3 -> v4:
>>> use "riscv" instead of "riscv64" in the summary of patch 5 subject line.
>>> Changes v4 -> v5:
>>> add a new patch "RISC-V: Fixup schedule out issue in machine_crash_shutdown()"
>>>
>>> Xianting Tian (6):
>>> RISC-V: use __smp_processor_id() instead of smp_processor_id()
>>> RISC-V: Add arch_crash_save_vmcoreinfo support
>>> riscv: Add modules to virtual kernel memory layout dump
>>> RISC-V: Fixup getting correct current pc
>>> riscv: crash_core: Export kernel vm layout, phys_ram_base
>>> RISC-V: Fixup schedule out issue in machine_crash_shutdown()
>>>
>>> .../admin-guide/kdump/vmcoreinfo.rst | 31 +++++++++++++++++++
>>> arch/riscv/kernel/Makefile | 1 +
>>> arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++
>>> arch/riscv/kernel/crash_save_regs.S | 2 +-
>>> arch/riscv/kernel/machine_kexec.c | 28 ++++++++++++++---
>>> arch/riscv/mm/init.c | 4 +++
>>> 6 files changed, 89 insertions(+), 6 deletions(-)
>>> create mode 100644 arch/riscv/kernel/crash_core.c
>>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-08-11 2:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 12:18 [PATCH V5 0/6] RISC-V fixups to work with crash tool Xianting Tian
2022-08-02 12:18 ` [PATCH V5 1/6] RISC-V: use __smp_processor_id() instead of smp_processor_id() Xianting Tian
2022-08-09 21:10 ` Conor.Dooley
2022-08-02 12:18 ` [PATCH V5 2/6] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-08-02 12:18 ` [PATCH V5 3/6] riscv: Add modules to virtual kernel memory layout dump Xianting Tian
2022-08-02 12:18 ` [PATCH V5 4/6] RISC-V: Fixup getting correct current pc Xianting Tian
2022-08-09 21:13 ` Conor.Dooley
2022-08-09 21:14 ` Conor.Dooley
2022-08-02 12:18 ` [PATCH V5 5/6] riscv: crash_core: Export kernel vm layout, phys_ram_base Xianting Tian
2022-08-09 21:20 ` Conor.Dooley
2022-08-10 12:00 ` Xianting Tian
2022-08-11 3:06 ` Bagas Sanjaya
2022-08-11 3:37 ` Xianting Tian
2022-08-02 12:18 ` [PATCH V5 6/6] RISC-V: Fixup schedule out issue in machine_crash_shutdown() Xianting Tian
2022-08-09 21:20 ` Conor.Dooley
2022-08-09 6:58 ` [PATCH V5 0/6] RISC-V fixups to work with crash tool Xianting Tian
2022-08-09 21:24 ` Conor.Dooley
2022-08-11 2:54 ` Xianting Tian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5afbd9b6-37c5-8a8d-6fdf-bca721ebd25e@linux.alibaba.com \
--to=xianting.tian@linux.alibaba.com \
--cc=Conor.Dooley@microchip.com \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=crash-utility@redhat.com \
--cc=dyoung@redhat.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=heinrich.schuchardt@canonical.com \
--cc=hschauhan@nulltrace.org \
--cc=huanyi.xj@alibaba-inc.com \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vgoyal@redhat.com \
--cc=yixun.lan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).