From: Alex Ghiti <alex@ghiti.fr>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: anup@brainfault.org, linux-kernel@vger.kernel.org,
zong.li@sifive.com, Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH 3/7] riscv: Simplify MAXPHYSMEM config
Date: Tue, 7 Apr 2020 01:13:10 -0400 [thread overview]
Message-ID: <61d65afd-1650-4e16-b93d-f6d44c95ada7@ghiti.fr> (raw)
In-Reply-To: <mhng-f28ea5f1-ad10-4216-8612-f92863d20cca@palmerdabbelt-glaptop1>
On 4/3/20 11:53 AM, Palmer Dabbelt wrote:
> On Sun, 22 Mar 2020 04:00:24 PDT (-0700), alex@ghiti.fr wrote:
>> Either the user specifies maximum physical memory size of 2GB or the
>> user lives with the system constraint which is 128GB in 64BIT for now.
>>
>> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
>> ---
>> arch/riscv/Kconfig | 20 ++++++--------------
>> 1 file changed, 6 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index 8e4b1cbcf2c2..a475c78e66bc 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -104,7 +104,7 @@ config PAGE_OFFSET
>> default 0xC0000000 if 32BIT && MAXPHYSMEM_2GB
>> default 0x80000000 if 64BIT && !MMU
>> default 0xffffffff80000000 if 64BIT && MAXPHYSMEM_2GB
>> - default 0xffffffe000000000 if 64BIT && MAXPHYSMEM_128GB
>> + default 0xffffffe000000000 if 64BIT && !MAXPHYSMEM_2GB
>>
>> config ARCH_FLATMEM_ENABLE
>> def_bool y
>> @@ -216,19 +216,11 @@ config MODULE_SECTIONS
>> bool
>> select HAVE_MOD_ARCH_SPECIFIC
>>
>> -choice
>> - prompt "Maximum Physical Memory"
>> - default MAXPHYSMEM_2GB if 32BIT
>> - default MAXPHYSMEM_2GB if 64BIT && CMODEL_MEDLOW
>> - default MAXPHYSMEM_128GB if 64BIT && CMODEL_MEDANY
>> -
>> - config MAXPHYSMEM_2GB
>> - bool "2GiB"
>> - config MAXPHYSMEM_128GB
>> - depends on 64BIT && CMODEL_MEDANY
>> - bool "128GiB"
>> -endchoice
>> -
>> +config MAXPHYSMEM_2GB
>> + bool "Maximum Physical Memory 2GiB"
>> + default y if 32BIT
>> + default y if 64BIT && CMODEL_MEDLOW
>> + default n
>>
>> config SMP
>> bool "Symmetric Multi-Processing"
>
> I'm not sure this actually helps with anything, but if it's all going
> away then it's
> fine. Originally the 2G/128G stuff was there to allow for larger VA
> spaces in
> the future.
With runtime sv48 introduction, whatever we would have used here could
have been wrong at runtime, so removing it was easier.
Alex
next prev parent reply other threads:[~2020-04-07 5:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 11:00 [RFC PATCH 0/7] Introduce sv48 support Alexandre Ghiti
2020-03-22 11:00 ` [RFC PATCH 1/7] riscv: Get rid of compile time logic with MAX_EARLY_MAPPING_SIZE Alexandre Ghiti
2020-03-26 6:10 ` Anup Patel
2020-04-03 15:17 ` Palmer Dabbelt
2020-04-07 5:12 ` Alex Ghiti
2020-03-22 11:00 ` [RFC PATCH 2/7] riscv: Allow to dynamically define VA_BITS Alexandre Ghiti
2020-03-26 6:12 ` Anup Patel
2020-04-03 15:17 ` Palmer Dabbelt
2020-04-07 5:12 ` Alex Ghiti
2020-03-22 11:00 ` [RFC PATCH 3/7] riscv: Simplify MAXPHYSMEM config Alexandre Ghiti
2020-03-26 6:22 ` Anup Patel
2020-03-26 6:34 ` Anup Patel
2020-04-03 15:53 ` Palmer Dabbelt
2020-04-07 5:13 ` Alex Ghiti [this message]
2020-03-22 11:00 ` [RFC PATCH 4/7] riscv: Implement sv48 support Alexandre Ghiti
2020-03-26 7:00 ` Anup Patel
2020-03-31 16:31 ` Alex Ghiti
2020-04-03 15:53 ` Palmer Dabbelt
2020-04-07 5:14 ` Alex Ghiti
2020-04-07 5:56 ` Anup Patel
2020-04-08 4:39 ` Alex Ghiti
2020-04-08 5:06 ` Anup Patel
2020-03-22 11:00 ` [RFC PATCH 5/7] riscv: Use pgtable_l4_enabled to output mmu type in cpuinfo Alexandre Ghiti
2020-03-26 7:01 ` Anup Patel
2020-04-03 15:53 ` Palmer Dabbelt
2020-04-07 5:14 ` Alex Ghiti
2020-03-22 11:00 ` [RFC PATCH 6/7] dt-bindings: riscv: Remove "riscv, svXX" property from device-tree Alexandre Ghiti
2020-03-26 7:03 ` Anup Patel
2020-04-03 15:53 ` Palmer Dabbelt
2020-04-07 5:14 ` Alex Ghiti
2020-03-22 11:00 ` [RFC PATCH 7/7] riscv: Explicit comment about user virtual address space size Alexandre Ghiti
2020-03-26 7:05 ` Anup Patel
2020-04-03 15:53 ` Palmer Dabbelt
2020-04-07 5:15 ` Alex Ghiti
2020-03-31 19:53 ` [RFC PATCH 0/7] Introduce sv48 support Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d65afd-1650-4e16-b93d-f6d44c95ada7@ghiti.fr \
--to=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).