From: <Conor.Dooley@microchip.com>
To: <maz@kernel.org>, <Lewis.Hanly@microchip.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linus.walleij@linaro.org>, <brgl@bgdev.pl>,
<linux-kernel@vger.kernel.org>, <palmer@dabbelt.com>,
<Daire.McNamara@microchip.com>
Subject: Re: [PATCH v3 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Sat, 16 Jul 2022 12:20:53 +0000 [thread overview]
Message-ID: <81f662a9-c820-9018-8dd7-f1f060ea0b54@microchip.com> (raw)
In-Reply-To: <87pmi549rp.wl-maz@kernel.org>
On 16/07/2022 11:44, Marc Zyngier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> A couple of other nits:
>
>> +static const struct of_device_id mpfs_of_ids[] = {
>> + { .compatible = "microchip,mpfs-gpio", },
>
> Where is the DT binding for this?
>
Upstreamed with the device tree entry in 5.18:
Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
Lewis: might be worth mentioning that in your cover letters.
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-07-16 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 7:11 [PATCH v3 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-07-16 7:11 ` [PATCH v3 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-07-16 10:33 ` Marc Zyngier
2022-07-16 15:21 ` Lewis.Hanly
2022-07-16 17:52 ` Marc Zyngier
2022-07-16 18:32 ` Conor.Dooley
2022-07-17 15:10 ` Marc Zyngier
2022-07-17 15:46 ` Conor.Dooley
2022-07-31 8:56 ` Lewis.Hanly
2022-07-16 10:44 ` Marc Zyngier
2022-07-16 12:17 ` Lewis.Hanly
2022-07-16 12:20 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81f662a9-c820-9018-8dd7-f1f060ea0b54@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Lewis.Hanly@microchip.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).