From: Peter Korsgaard <peter@korsgaard.com>
To: Sagar Kadam <sagar.kadam@openfive.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Paul Walmsley \( Sifive\)" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/1] i2c: ocores: fix polling mode workaround on FU540-C000 SoC
Date: Thu, 08 Oct 2020 18:05:30 +0200 [thread overview]
Message-ID: <87eem84sad.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <DM6PR13MB345137AD526D0AAA6CE0DBDF970B0@DM6PR13MB3451.namprd13.prod.outlook.com> (Sagar Kadam's message of "Thu, 8 Oct 2020 13:53:55 +0000")
>>>>> "Sagar" == Sagar Kadam <sagar.kadam@openfive.com> writes:
> Hello Peter,
>> Are both affected by this issue? if not, we will need to extend the code
>> to handle them differently.
>>
> No, this issue is present in FU540-C000 SoC i.e SoC- specific, and so I can check
> for the soc-compatible string as follows:
> - match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
> - if (match && (long)match->data == TYPE_SIFIVE_REV0)
> + if (of_device_is_compatible(pdev->dev.of_node,
> + "sifive,fu540-c000-i2c"))
> Please let me know if this is okay.
Yes, that sounds sensible. Thanks.
--
Bye, Peter Korsgaard
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-10-08 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 17:53 [PATCH 0/1] fix i2c polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2020-10-06 17:53 ` [PATCH 1/1] i2c: ocores: fix polling mode workaround on " Sagar Shrikant Kadam
2020-10-07 11:40 ` Peter Korsgaard
2020-10-08 13:53 ` Sagar Kadam
2020-10-08 16:05 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eem84sad.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=andrew@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sagar.kadam@openfive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).