From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
Date: Fri, 1 Sep 2023 22:12:41 +0100 [thread overview]
Message-ID: <CA+V-a8tyUpgDSBrpHBBfWfie4xnR7iKCZben3U5dX1puFu3_1A@mail.gmail.com> (raw)
In-Reply-To: <c9da6ffe-7a58-1efa-f625-41d73346d6a2@infradead.org>
Hi Randy,
On Fri, Sep 1, 2023 at 9:27 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> On 9/1/23 04:03, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> > enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> > avoid any build failures.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > arch/riscv/Kconfig.errata | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> > index bee5d838763b..566bcefeab50 100644
> > --- a/arch/riscv/Kconfig.errata
> > +++ b/arch/riscv/Kconfig.errata
> > @@ -2,7 +2,7 @@ menu "CPU errata selection"
> >
> > config ERRATA_ANDES
> > bool "Andes AX45MP errata"
> > - depends on RISCV_ALTERNATIVE
> > + depends on RISCV_ALTERNATIVE && RISCV_SBI
> > help
> > All Andes errata Kconfig depend on this Kconfig. Disabling
> > this Kconfig will disable all Andes errata. Please say "Y"
>
>
> I'm still seeing build warnings/errors after applying all 3 RISC-V
> Kconfig patches from today (2023 SEP 01).
>
> WARNING: unmet direct dependencies detected for ERRATA_ANDES
> Depends on [n]: RISCV_ALTERNATIVE [=y] && RISCV_SBI [=n]
> Selected by [y]:
> - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y]
>
> ../arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workaround':
> ../arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known
> 29 | struct sbiret ret;
> | ^~~
> ../arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration of function 'sbi_ecall' [-Werror=implicit-function-declaration]
> 35 | ret = sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_SBI_EXT_IOCP_SW_WORKAROUND,
> | ^~~~~~~~~
> ../arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 'ret' [-Wunused-variable]
> 29 | struct sbiret ret;
> | ^~~
>
> ARCH_R9A07G043 in drivers/soc/renesas/Kconfig selects ERRATA_ANDES and
> ERRATA_ANDES_CMO even though RISCV_SBI is not set/enabled.
>
You need to apply patch [1] aswell.
[1] https://patchwork.kernel.org/project/linux-riscv/patch/20230901110936.313171-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
Cheers,
Prabhakar
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-09-01 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 11:03 [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Prabhakar
2023-09-01 11:47 ` Geert Uytterhoeven
2023-09-01 20:27 ` Randy Dunlap
2023-09-01 21:12 ` Lad, Prabhakar [this message]
2023-09-02 0:47 ` Randy Dunlap
2023-09-02 8:20 ` Conor Dooley
2023-09-02 11:02 ` Conor Dooley
2023-09-05 7:52 ` Lad, Prabhakar
2023-09-06 2:50 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8tyUpgDSBrpHBBfWfie4xnR7iKCZben3U5dX1puFu3_1A@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).