From: Anup Patel <anup@brainfault.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Radim K <rkrcmar@redhat.com>, Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 11/19] RISC-V: KVM: Implement VMID allocator
Date: Tue, 6 Aug 2019 08:49:24 +0530 [thread overview]
Message-ID: <CAAhSdy03G-8S0y7kg96PzC-4npdEFv+WCCuBvoCbEt9244kDOg@mail.gmail.com> (raw)
In-Reply-To: <21bdde39-8d33-6aae-e729-476ce11406a3@redhat.com>
On Mon, Aug 5, 2019 at 9:33 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 05/08/19 15:43, Anup Patel wrote:
> > + spin_lock(&vmid_lock);
> > +
> > + /*
> > + * We need to re-check the vmid_version here to ensure that if
> > + * another vcpu already allocated a valid vmid for this vm.
> > + */
> > + if (!kvm_riscv_stage2_vmid_ver_changed(vmid)) {
> > + spin_unlock(&vmid_lock);
> > + return;
> > + }
> > +
> > + /* First user of a new VMID version? */
> > + if (unlikely(vmid_next == 0)) {
> > + WRITE_ONCE(vmid_version, READ_ONCE(vmid_version) + 1);
> > + vmid_next = 1;
> > +
> > + /*
> > + * On SMP, we know no other CPUs can use this CPU's or
> > + * each other's VMID after forced exit returns since the
> > + * vmid_lock blocks them from re-entry to the guest.
> > + */
> > + spin_unlock(&vmid_lock);
> > + kvm_flush_remote_tlbs(vcpu->kvm);
> > + spin_lock(&vmid_lock);
>
> This comment is not true anymore, so this "if" should become a "while".
Sure, I will update in v4.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-06 3:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 13:42 [PATCH v3 00/19] KVM RISC-V Support Anup Patel
2019-08-05 13:42 ` [PATCH v3 01/19] KVM: RISC-V: Add KVM_REG_RISCV for ONE_REG interface Anup Patel
2019-08-05 13:42 ` [PATCH v3 02/19] RISC-V: Export few kernel symbols Anup Patel
2019-08-05 13:42 ` [PATCH v3 03/19] RISC-V: Add hypervisor extension related CSR defines Anup Patel
2019-08-05 13:43 ` [PATCH v3 04/19] RISC-V: Add initial skeletal KVM support Anup Patel
2019-08-05 13:43 ` [PATCH v3 05/19] RISC-V: KVM: Implement VCPU create, init and destroy functions Anup Patel
2019-08-05 13:43 ` [PATCH v3 06/19] RISC-V: KVM: Implement VCPU interrupts and requests handling Anup Patel
2019-08-06 3:18 ` Anup Patel
2019-08-05 13:43 ` [PATCH v3 07/19] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls Anup Patel
2019-08-05 13:43 ` [PATCH v3 08/19] RISC-V: KVM: Implement VCPU world-switch Anup Patel
2019-08-05 13:43 ` [PATCH v3 09/19] RISC-V: KVM: Handle MMIO exits for VCPU Anup Patel
2019-08-05 13:43 ` [PATCH v3 10/19] RISC-V: KVM: Handle WFI " Anup Patel
2019-08-05 13:43 ` [PATCH v3 11/19] RISC-V: KVM: Implement VMID allocator Anup Patel
2019-08-05 16:03 ` Paolo Bonzini
2019-08-06 3:19 ` Anup Patel [this message]
2019-08-06 10:44 ` Anup Patel
2019-08-05 13:43 ` [PATCH v3 12/19] RISC-V: KVM: Implement stage2 page table programming Anup Patel
2019-08-05 13:43 ` [PATCH v3 13/19] RISC-V: KVM: Implement MMU notifiers Anup Patel
2019-08-05 13:44 ` [PATCH v3 14/19] RISC-V: KVM: Add timer functionality Anup Patel
2019-08-05 13:44 ` [PATCH v3 15/19] RISC-V: KVM: FP lazy save/restore Anup Patel
2019-08-05 13:44 ` [PATCH v3 16/19] RISC-V: KVM: Implement ONE REG interface for FP registers Anup Patel
2019-08-05 13:44 ` [PATCH v3 17/19] RISC-V: KVM: Add SBI v0.1 support Anup Patel
2019-08-05 13:44 ` [PATCH v3 18/19] RISC-V: Enable VIRTIO drivers in RV64 and RV32 defconfig Anup Patel
2019-08-05 13:44 ` [PATCH v3 19/19] RISC-V: KVM: Add MAINTAINERS entry Anup Patel
2019-08-05 16:05 ` [PATCH v3 00/19] KVM RISC-V Support Paolo Bonzini
2019-08-05 22:28 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy03G-8S0y7kg96PzC-4npdEFv+WCCuBvoCbEt9244kDOg@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).