From: Anup Patel <anup@brainfault.org>
To: liush <liush@allwinnertech.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
peterx@redhat.com, daniel.m.jordan@oracle.com,
Palmer Dabbelt <palmer@dabbelt.com>,
Mike Rapoport <rppt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
walken@google.com, linux-riscv <linux-riscv@lists.infradead.org>,
vbabka@suse.cz
Subject: Re: [PATCH] riscv: fix pfn_to_virt err in do_page_fault().
Date: Thu, 17 Sep 2020 13:29:12 +0530 [thread overview]
Message-ID: <CAAhSdy1kn5K3aH3-LP9zy2R-Xq0ha9RqjBnBd8y9xZkCEn0rsg@mail.gmail.com> (raw)
In-Reply-To: <1600327549-3995-1-git-send-email-liush@allwinnertech.com>
On Thu, Sep 17, 2020 at 12:56 PM liush <liush@allwinnertech.com> wrote:
>
> The argument to pfn_to_virt() should be pfn not the value of CSR_SATP.
>
> Signed-off-by: liush <liush@allwinnertech.com>
> ---
> arch/riscv/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
> index 716d64e..9b4e088 100644
> --- a/arch/riscv/mm/fault.c
> +++ b/arch/riscv/mm/fault.c
> @@ -212,7 +212,7 @@ asmlinkage void do_page_fault(struct pt_regs *regs)
> * of a task switch.
> */
> index = pgd_index(addr);
> - pgd = (pgd_t *)pfn_to_virt(csr_read(CSR_SATP)) + index;
> + pgd = (pgd_t *)pfn_to_virt(csr_read(CSR_SATP) & SATP_PPN) + index;
> pgd_k = init_mm.pgd + index;
>
> if (!pgd_present(*pgd_k))
> --
> 2.7.4
>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-09-17 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 7:25 [PATCH] riscv: fix pfn_to_virt err in do_page_fault() liush
2020-09-17 7:59 ` Anup Patel [this message]
2020-09-17 15:25 ` Christoph Hellwig
2020-09-18 7:43 ` 回复：[PATCH] " 刘邵华BTD
2020-09-28 9:31 ` fuyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy1kn5K3aH3-LP9zy2R-Xq0ha9RqjBnBd8y9xZkCEn0rsg@mail.gmail.com \
--to=anup@brainfault.org \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=liush@allwinnertech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).