From: Vincent Chen <vincent.chen@sifive.com>
To: Anup Patel <anup@brainfault.org>
Cc: linux-riscv <linux-riscv@lists.infradead.org>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH 2/2] riscv: Make __fstate_clean() can work correctly.
Date: Wed, 14 Aug 2019 09:55:00 +0800 [thread overview]
Message-ID: <CABvJ_xjvot3xuHrbmV01hzejx7y6ty2Oy-BNLRfa=Fq4=u3dFA@mail.gmail.com> (raw)
In-Reply-To: <CAAhSdy0+FeZecT0Xppwq+fGu-BV7dp+zY141R73=0O=khKdOKQ@mail.gmail.com>
On Thu, Aug 8, 2019 at 6:17 PM Anup Patel <anup@brainfault.org> wrote:
>
> On Thu, Aug 8, 2019 at 1:30 PM Vincent Chen <vincent.chen@sifive.com> wrote:
> >
> > Make the __fstate_clean() function can correctly set the
> > state of sstatus.FS in pt_regs to SR_FS_CLEAN.
> >
> > Tested on both QEMU and HiFive Unleashed using BBL + Linux.
> >
> > Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
> > ---
> > arch/riscv/include/asm/switch_to.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/include/asm/switch_to.h b/arch/riscv/include/asm/switch_to.h
> > index d5fe573..544f99a 100644
> > --- a/arch/riscv/include/asm/switch_to.h
> > +++ b/arch/riscv/include/asm/switch_to.h
> > @@ -16,7 +16,7 @@ extern void __fstate_restore(struct task_struct *restore_from);
> >
> > static inline void __fstate_clean(struct pt_regs *regs)
> > {
> > - regs->sstatus |= (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN;
> > + regs->sstatus = (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN;
> > }
> >
> > static inline void fstate_off(struct task_struct *task,
> > --
> > 2.7.4
> >
>
> Looks good to me.
>
> Reviewed-by: Anup Patel <anup@brainfault.org>
>
> This should be a RC fix.
>
> Please add "Fixes:" in your commit description and
> CC stable kernel.
>
OK, I will follow your suggestions and resend this patch
Thanks for your comments.
Regards,
Vincent Chen
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-14 1:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:58 [PATCH 0/2] riscv: Correct the initialized flow of FP and __fstate_clean() Vincent Chen
2019-08-08 7:58 ` [PATCH 1/2] riscv: Correct the initialized flow of FP register Vincent Chen
2019-08-08 10:15 ` Anup Patel
2019-08-08 15:50 ` Paul Walmsley
2019-08-14 1:45 ` Vincent Chen
2019-08-14 3:51 ` Anup Patel
2019-08-12 14:58 ` Christoph Hellwig
2019-08-14 1:52 ` Vincent Chen
2019-08-08 7:58 ` [PATCH 2/2] riscv: Make __fstate_clean() can work correctly Vincent Chen
2019-08-08 10:17 ` Anup Patel
2019-08-14 1:55 ` Vincent Chen [this message]
2019-08-12 14:59 ` Christoph Hellwig
2019-08-14 1:55 ` Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABvJ_xjvot3xuHrbmV01hzejx7y6ty2Oy-BNLRfa=Fq4=u3dFA@mail.gmail.com' \
--to=vincent.chen@sifive.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).