From: Yash Shah <yash.shah@sifive.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, "Albert Ou" <aou@eecs.berkeley.edu>,
netdev <netdev@vger.kernel.org>,
"Palmer Dabbelt" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Sachin Ghadi" <sachin.ghadi@sifive.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Petr Štetiar" <ynezz@true.cz>,
linux-riscv@lists.infradead.org,
"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding
Date: Fri, 24 May 2019 10:26:32 +0530 [thread overview]
Message-ID: <CAJ2_jOEErFdK=n7Brk5A_950vfikdFcxcRri4HXgJWqf0-zR=w@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+p5PnTDgxuh9_Aw1RvTk4aTYjKxyMq7DPczLzQVv8_ew@mail.gmail.com>
On Fri, May 24, 2019 at 2:20 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Thu, May 23, 2019 at 6:46 AM Yash Shah <yash.shah@sifive.com> wrote:
> >
> > Add the compatibility string documentation for SiFive FU540-C0000
> > interface.
> > On the FU540, this driver also needs to read and write registers in a
> > management IP block that monitors or drives boundary signals for the
> > GEMGXL IP block that are not directly mapped to GEMGXL registers.
> > Therefore, add additional range to "reg" property for SiFive GEMGXL
> > management IP registers.
> >
> > Signed-off-by: Yash Shah <yash.shah@sifive.com>
> > ---
> > Documentation/devicetree/bindings/net/macb.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> > index 9c5e944..91a2a66 100644
> > --- a/Documentation/devicetree/bindings/net/macb.txt
> > +++ b/Documentation/devicetree/bindings/net/macb.txt
> > @@ -4,6 +4,7 @@ Required properties:
> > - compatible: Should be "cdns,[<chip>-]{macb|gem}"
> > Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.
> > Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
> > + Use "cdns,fu540-macb" for SiFive FU540-C000 SoC.
>
> This pattern that Atmel started isn't really correct. The vendor
> prefix here should be sifive. 'cdns' would be appropriate for a
> fallback.
Ok sure. WIll change it to "sifive,fu540-macb"
Thanks for your comment.
- Yash
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-24 4:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 11:45 [PATCH 0/2] net: macb: Add support for SiFive FU540-C000 Yash Shah
2019-05-23 11:45 ` [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding Yash Shah
2019-05-23 20:50 ` Rob Herring
2019-05-24 4:56 ` Yash Shah [this message]
2019-06-24 15:38 ` Nicolas.Ferre
2019-07-17 9:07 ` Yash Shah
2019-05-23 11:45 ` [PATCH 2/2] net: macb: Add support for SiFive FU540-C000 Yash Shah
2019-05-23 14:54 ` Andrew Lunn
2019-05-24 4:52 ` Yash Shah
2019-05-24 13:48 ` Andrew Lunn
2019-05-30 2:42 ` Palmer Dabbelt
2019-05-23 12:49 ` [PATCH 0/2] " Andreas Schwab
2019-05-24 4:39 ` Yash Shah
2019-05-27 8:04 ` Andreas Schwab
2019-05-27 11:52 ` Yash Shah
2019-05-23 16:28 ` David Miller
2019-05-24 4:54 ` Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ2_jOEErFdK=n7Brk5A_950vfikdFcxcRri4HXgJWqf0-zR=w@mail.gmail.com' \
--to=yash.shah@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).